mojo/services/keyboard/interfaces/keyboard.mojom - Issue 1454113003: Require an explicit ServiceName annotation for interfaces in C++.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: mojo/services/keyboard/interfaces/keyboard.mojom

Issue 1454113003: Require an explicit ServiceName annotation for interfaces in C++. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 [DartPackage="mojo_services"]	5 [DartPackage="mojo_services"]

6 module keyboard;	6 module keyboard;

7	7

8 struct CompletionData {	8 struct CompletionData {

9 int64 id;	9 int64 id;

10 int32 position;	10 int32 position;

(...skipping 24 matching lines...) Expand all Loading...
35	35

36 // Loosely modeled on Android InputType:	36 // Loosely modeled on Android InputType:

37 // http://developer.android.com/reference/android/text/InputType.html	37 // http://developer.android.com/reference/android/text/InputType.html

38 enum KeyboardType {	38 enum KeyboardType {

39 TEXT,	39 TEXT,

40 NUMBER,	40 NUMBER,

41 PHONE,	41 PHONE,

42 DATETIME,	42 DATETIME,

43 };	43 };

44	44

	45 [ServiceName="keyboard::KeyboardService"]

45 interface KeyboardService {	46 interface KeyboardService {

46 Show(KeyboardClient client, KeyboardType type);	47 Show(KeyboardClient client, KeyboardType type);

47 ShowByRequest();	48 ShowByRequest();

48 Hide();	49 Hide();

49 SetText(string text);	50 SetText(string text);

50 SetSelection(int32 start, int32 end);	51 SetSelection(int32 start, int32 end);

51 };	52 };

OLD	NEW