mojo/services/icu_data/interfaces/icu_data.mojom - Issue 1454113003: Require an explicit ServiceName annotation for interfaces in C++.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/icu_data/interfaces/icu_data.mojom

Issue 1454113003: Require an explicit ServiceName annotation for interfaces in C++. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/services/icu_data/interfaces/icu_data.mojom

diff --git a/mojo/services/icu_data/interfaces/icu_data.mojom b/mojo/services/icu_data/interfaces/icu_data.mojom

index ced5aa64359941c8bcdc962d2ace971239b1e5f2..886b1a3803dd8cff0cfa1630f14a23fa9033497c 100644

--- a/mojo/services/icu_data/interfaces/icu_data.mojom

+++ b/mojo/services/icu_data/interfaces/icu_data.mojom

@@ -5,6 +5,7 @@

[DartPackage="mojo_services"]

module icu_data;

+[ServiceName="icu_data::ICUData"]

interface ICUData {

Map(string sha1hash) => (handle<shared_buffer>? icu_data);

};