Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Side by Side Diff: mojo/services/native_support/interfaces/process.mojom

Issue 1454113003: Require an explicit ServiceName annotation for interfaces in C++. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 [DartPackage="mojo_services"] 5 [DartPackage="mojo_services"]
6 module native_support; 6 module native_support;
7 7
8 import "files/interfaces/file.mojom"; 8 import "files/interfaces/file.mojom";
9 import "files/interfaces/types.mojom"; 9 import "files/interfaces/types.mojom";
10 10
11 // Interface for dealing with (e.g., starting) "native" processes. 11 // Interface for dealing with (e.g., starting) "native" processes.
12 [ServiceName="native_support::Process"]
12 interface Process { 13 interface Process {
13 // Spawns a process, optionally redirecting stdin/stdout/stderr from/to the 14 // Spawns a process, optionally redirecting stdin/stdout/stderr from/to the
14 // corresponding |mojo.files.File| (if null, redirects from/to /dev/null). 15 // corresponding |mojo.files.File| (if null, redirects from/to /dev/null).
15 // |path| is the path to the binary to execute; |argv| is the argv to give to 16 // |path| is the path to the binary to execute; |argv| is the argv to give to
16 // the process (if null, it just takes |argv[0]| to be |path| with no other 17 // the process (if null, it just takes |argv[0]| to be |path| with no other
17 // arguments); |envp| is the environment to give to the process, consisting of 18 // arguments); |envp| is the environment to give to the process, consisting of
18 // an array of "strings" of the form "NAME=value" (if null, simply inherits 19 // an array of "strings" of the form "NAME=value" (if null, simply inherits
19 // the environment from the parent, whatever that is). 20 // the environment from the parent, whatever that is).
20 // TODO(vtl): This should really take an array of |mojo.files.File|s (or maybe 21 // TODO(vtl): This should really take an array of |mojo.files.File|s (or maybe
21 // two, one for input and the other for output), corresponding to FDs, but the 22 // two, one for input and the other for output), corresponding to FDs, but the
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 // Kill the process with the given signal (note: does not wait). |signal| 57 // Kill the process with the given signal (note: does not wait). |signal|
57 // should be nonnegative. This is not valid after a successful call to 58 // should be nonnegative. This is not valid after a successful call to
58 // |Wait()|. 59 // |Wait()|.
59 // TODO(vtl): Add constants for signals. (For standard POSIX signals, the 60 // TODO(vtl): Add constants for signals. (For standard POSIX signals, the
60 // values should be the same as the POSIX-specified values, so using POSIX 61 // values should be the same as the POSIX-specified values, so using POSIX
61 // macros for the values should always be OK.) 62 // macros for the values should always be OK.)
62 Kill(int32 signal) => (mojo.files.Error error); 63 Kill(int32 signal) => (mojo.files.Error error);
63 64
64 // TODO(vtl): Add a "Detach()"? 65 // TODO(vtl): Add a "Detach()"?
65 }; 66 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698