mojo/services/window_manager/interfaces/window_manager.mojom - Issue 1454113003: Require an explicit ServiceName annotation for interfaces in C++.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/window_manager/interfaces/window_manager.mojom

Issue 1454113003: Require an explicit ServiceName annotation for interfaces in C++. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/services/window_manager/interfaces/window_manager.mojom

diff --git a/mojo/services/window_manager/interfaces/window_manager.mojom b/mojo/services/window_manager/interfaces/window_manager.mojom

index 1b9d0b7b40de67f5536c9ae63453a562c4cce128..9203003ef30790ed172a2bf9347a7ec7352bd1bb 100644

--- a/mojo/services/window_manager/interfaces/window_manager.mojom

+++ b/mojo/services/window_manager/interfaces/window_manager.mojom

@@ -8,6 +8,7 @@ module mojo;

import "input_events/interfaces/input_events.mojom";

import "mojo/public/interfaces/application/service_provider.mojom";

+[ServiceName="mojo::WindowManager"]

interface WindowManager {

// Requests the WindowManager to embed the app for |url| at an appropriate

// View. See ViewMangerService::Embed() for details on |services| and