mojo/services/notifications/interfaces/notifications.mojom - Issue 1454113003: Require an explicit ServiceName annotation for interfaces in C++.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/notifications/interfaces/notifications.mojom

Issue 1454113003: Require an explicit ServiceName annotation for interfaces in C++. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/services/notifications/interfaces/notifications.mojom

diff --git a/mojo/services/notifications/interfaces/notifications.mojom b/mojo/services/notifications/interfaces/notifications.mojom

index df2d6717f7e999363fac6e4bb4acf6ee34ca2700..df36918a38d85d6d5b2eb64c641ecd58ca21f9a1 100644

--- a/mojo/services/notifications/interfaces/notifications.mojom

+++ b/mojo/services/notifications/interfaces/notifications.mojom

@@ -34,6 +34,7 @@ interface Notification {

Cancel();

};

+[ServiceName="notifications::NotificationService"]

interface NotificationService {

// Posts a new notification with the information specified in

// |notification_data| and with any interactions with the notification being