Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: mojo/services/view_manager/interfaces/view_manager.mojom

Issue 1454113003: Require an explicit ServiceName annotation for interfaces in C++. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/view_manager/interfaces/view_manager.mojom
diff --git a/mojo/services/view_manager/interfaces/view_manager.mojom b/mojo/services/view_manager/interfaces/view_manager.mojom
index 8c3dc0d8b099042fb63b2fbf0102862a654b03c7..becf941044bb9f695d9f48da31c90efb2ba8d7ef 100644
--- a/mojo/services/view_manager/interfaces/view_manager.mojom
+++ b/mojo/services/view_manager/interfaces/view_manager.mojom
@@ -36,6 +36,7 @@ enum ErrorCode {
// and the lower 16 the id assigned by the client.
//
// The root view is identified with a connection id of 0, and value of 1.
+[ServiceName="mojo::ViewManagerService"]
interface ViewManagerService {
// Creates a new view with the specified id. It is up to the client to ensure
// the id is unique to the connection (the id need not be globally unique).
@@ -156,6 +157,7 @@ interface ViewManagerService {
// Changes to views are not sent to the connection that originated the
// change. For example, if connection 1 changes the bounds of a view by calling
// SetBounds(), connection 1 does not receive OnViewBoundsChanged().
+[ServiceName="mojo::ViewManagerClient"]
interface ViewManagerClient {
// Invoked when the client application has been embedded at |root|.
// See Embed() on ViewManagerService for more details. |view_manager_service|

Powered by Google App Engine
This is Rietveld 408576698