services/test_service/test_service.mojom - Issue 1454113003: Require an explicit ServiceName annotation for interfaces in C++.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/test_service/test_service.mojom

Issue 1454113003: Require an explicit ServiceName annotation for interfaces in C++. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: services/test_service/test_service.mojom

diff --git a/services/test_service/test_service.mojom b/services/test_service/test_service.mojom

index 5144addc6139b6d8141d02a1a56dc8b9b157faf3..88486430be4d012e8ea5245fc5d6251d0a7895b9 100644

--- a/services/test_service/test_service.mojom

+++ b/services/test_service/test_service.mojom

@@ -4,6 +4,7 @@

module mojo.test;

+[ServiceName="mojo::test::TestService"]

interface TestService {

Ping() => ();

// Connect to a TestTimeService at |app_url| and ferry the data back

@@ -12,6 +13,7 @@ interface TestService {

StartTrackingRequests() => ();

};

+[ServiceName="mojo::test::TestTimeService"]

interface TestTimeService {

// Provides a constant time value.

GetPartyTime() => (int64 time_usec);