mojo/public/tools/bindings/pylib/mojom/generate/mojom_translator.py - Issue 1454113003: Require an explicit ServiceName annotation for interfaces in C++.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/pylib/mojom/generate/mojom_translator.py

Issue 1454113003: Require an explicit ServiceName annotation for interfaces in C++. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/tools/bindings/pylib/mojom/generate/data.py ('k') | mojo/services/asset_bundle/interfaces/asset_bundle.mojom » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/pylib/mojom/generate/mojom_translator.py

diff --git a/mojo/public/tools/bindings/pylib/mojom/generate/mojom_translator.py b/mojo/public/tools/bindings/pylib/mojom/generate/mojom_translator.py

index 52ccf926d4a944075bdda475acd72988137b9729..a31189fd9c4131945599a32e1e2b8b1b647657e7 100755

--- a/mojo/public/tools/bindings/pylib/mojom/generate/mojom_translator.py

+++ b/mojo/public/tools/bindings/pylib/mojom/generate/mojom_translator.py

@@ -374,6 +374,9 @@ class FileTranslator(object):

== mojom_types_mojom.UserDefinedType.Tags.interface_type)

mojom_interface = mojom_type.interface_type

interface.attributes = self.AttributesFromMojom(mojom_interface)

+ interface.service_name = None

+ if interface.attributes:

+ interface.service_name = interface.attributes.get('ServiceName')

self.PopulateModuleOrImportedFrom(interface, mojom_interface)

interface.name = mojom_interface.interface_name

interface.methods = [self.MethodFromMojom(mojom_method, interface)