mojo/services/asset_bundle/interfaces/asset_bundle.mojom - Issue 1454113003: Require an explicit ServiceName annotation for interfaces in C++.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/asset_bundle/interfaces/asset_bundle.mojom

Issue 1454113003: Require an explicit ServiceName annotation for interfaces in C++. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/services/asset_bundle/interfaces/asset_bundle.mojom

diff --git a/mojo/services/asset_bundle/interfaces/asset_bundle.mojom b/mojo/services/asset_bundle/interfaces/asset_bundle.mojom

index e9b43cd11e8c248417ae05216b9c6ad0cc13e632..d6ccc3c9dcbd08ae6884c6a7dc97a58f5259a898 100644

--- a/mojo/services/asset_bundle/interfaces/asset_bundle.mojom

+++ b/mojo/services/asset_bundle/interfaces/asset_bundle.mojom

@@ -5,10 +5,12 @@

[DartPackage="mojo_services"]

module mojo.asset_bundle;

+[ServiceName="mojo::asset_bundle::AssetBundle"]

interface AssetBundle {

GetAsStream(string asset_name) => (handle<data_pipe_consumer> asset_data);

};

+[ServiceName="mojo::asset_bundle::AssetUnpacker"]

interface AssetUnpacker {

UnpackZipStream(handle<data_pipe_consumer> zipped_assets, AssetBundle& asset_bundle);

};