Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: mojo/services/native_viewport/interfaces/native_viewport.mojom

Issue 1454113003: Require an explicit ServiceName annotation for interfaces in C++. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/native_viewport/interfaces/native_viewport.mojom
diff --git a/mojo/services/native_viewport/interfaces/native_viewport.mojom b/mojo/services/native_viewport/interfaces/native_viewport.mojom
index 34654146fc1560d0ad1c496f9eb319e1c38b3e1c..a70db13f455f896a369efa1f60bc15d83414f7c9 100644
--- a/mojo/services/native_viewport/interfaces/native_viewport.mojom
+++ b/mojo/services/native_viewport/interfaces/native_viewport.mojom
@@ -23,6 +23,7 @@ struct SurfaceConfiguration {
uint8 stencil_bits;
};
+[ServiceName="mojo::NativeViewport"]
interface NativeViewport {
// TODO(sky): having a create function is awkward. Should there be a factory
// to create the NativeViewport that takes the size?
@@ -47,6 +48,7 @@ interface NativeViewport {
RequestMetrics() => (ViewportMetrics metrics);
};
+[ServiceName="mojo::NativeViewportEventDispatcher"]
interface NativeViewportEventDispatcher {
OnEvent(Event event) => ();
};
« no previous file with comments | « mojo/services/native_support/interfaces/process.mojom ('k') | mojo/services/navigation/interfaces/navigation.mojom » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698