mojo/services/url_response_disk_cache/interfaces/url_response_disk_cache.mojom - Issue 1454113003: Require an explicit ServiceName annotation for interfaces in C++.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/url_response_disk_cache/interfaces/url_response_disk_cache.mojom

Issue 1454113003: Require an explicit ServiceName annotation for interfaces in C++. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/services/ui/views/interfaces/view_provider.mojom ('k') | mojo/services/vanadium/security/interfaces/principal.mojom » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/services/url_response_disk_cache/interfaces/url_response_disk_cache.mojom

diff --git a/mojo/services/url_response_disk_cache/interfaces/url_response_disk_cache.mojom b/mojo/services/url_response_disk_cache/interfaces/url_response_disk_cache.mojom

index abeb62f7d30b73bb56995e8e7db730449ac81e63..ebd6934ccedb106634b832c07ba5b9e6840f1a83 100644

--- a/mojo/services/url_response_disk_cache/interfaces/url_response_disk_cache.mojom

+++ b/mojo/services/url_response_disk_cache/interfaces/url_response_disk_cache.mojom

@@ -15,6 +15,7 @@ import "mojo/public/interfaces/network/url_response.mojom";

// ETags, the entry will be invalidated. It should be extended to

// handle all the other http cache mechanisms for better performance

// with http servers that do not support ETags.

+[ServiceName="mojo::URLResponseDiskCache"]

interface URLResponseDiskCache {

// Given an URL, returns a tuple. If the |url| is not in the cache, all the