mojo/services/device_info/interfaces/device_info.mojom - Issue 1454113003: Require an explicit ServiceName annotation for interfaces in C++.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/device_info/interfaces/device_info.mojom

Issue 1454113003: Require an explicit ServiceName annotation for interfaces in C++. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/services/device_info/interfaces/device_info.mojom

diff --git a/mojo/services/device_info/interfaces/device_info.mojom b/mojo/services/device_info/interfaces/device_info.mojom

index d31118d666326659b3a657dd3989f8797bc7ce0b..8df6e5df8acfaee1beabda973b32191254cc131d 100644

--- a/mojo/services/device_info/interfaces/device_info.mojom

+++ b/mojo/services/device_info/interfaces/device_info.mojom

@@ -7,6 +7,7 @@ module mojo;

// A service to expose device specific information.

// All operations are stateless.

+[ServiceName="mojo::DeviceInfo"]

interface DeviceInfo {

// The device type this service is running on. It can be a function of things

// like whether there's an attached screen and its size, etc.