mojo/public/tools/bindings/pylib/mojom/generate/data.py - Issue 1454113003: Require an explicit ServiceName annotation for interfaces in C++.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/pylib/mojom/generate/data.py

Issue 1454113003: Require an explicit ServiceName annotation for interfaces in C++. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/public/tools/bindings/pylib/mojom/generate/data.py

diff --git a/mojo/public/tools/bindings/pylib/mojom/generate/data.py b/mojo/public/tools/bindings/pylib/mojom/generate/data.py

index dfc23f1d743d5670b924f262945136a307bc1e0c..fad8fbc8fac0e11da841ed3fa9a8480053fcce1c 100644

--- a/mojo/public/tools/bindings/pylib/mojom/generate/data.py

+++ b/mojo/public/tools/bindings/pylib/mojom/generate/data.py

@@ -358,6 +358,9 @@ def InterfaceFromData(module, data):

# Stash methods data here temporarily.

interface.methods_data = data['methods']

interface.attributes = data.get('attributes')

+ interface.service_name = None

+ if interface.attributes:

+ interface.service_name = interface.attributes.get('ServiceName')

return interface

def EnumFieldFromData(module, enum, data, parent_kind):