mojo/services/surfaces/interfaces/surfaces.mojom - Issue 1454113003: Require an explicit ServiceName annotation for interfaces in C++.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/surfaces/interfaces/surfaces.mojom

Issue 1454113003: Require an explicit ServiceName annotation for interfaces in C++. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/services/surfaces/interfaces/surfaces.mojom

diff --git a/mojo/services/surfaces/interfaces/surfaces.mojom b/mojo/services/surfaces/interfaces/surfaces.mojom

index d31b505ad51d20edbe862bedc918894c72a6004c..ff71b3bb7460c992bcca90045c10e34f7f06d25c 100644

--- a/mojo/services/surfaces/interfaces/surfaces.mojom

+++ b/mojo/services/surfaces/interfaces/surfaces.mojom

@@ -55,6 +55,7 @@ interface ResourceReturner {

ReturnResources(array<ReturnedResource> resources);

};

+[ServiceName="mojo::Surface"]

interface Surface {

// Request the id namespace for this connection. Fully qualified surface ids

// are the combination of the id_namespace for the connection that created the