Rename avatar_url to icon_url in PasswordForm.

Rename avatar_url to icon_url in PasswordForm.

As specified in https://w3c.github.io/webappsec/specs/credentialmanagement/#credential

Do not rename it in the password store backends and sync yet:
- native_backend_gnome_x: string_attr_map["avatar_url"]
- native_backend_kwallet_x: {no names, just order}
- native_backend_libsecret: secret_password_store_sync(..., "avatar_url", ...)
- login_database: "CREATE TABLE ... avatar_url ..."
- password_syncable_service: password_specifics->set_avatar_url(...)

These changes will be done in follow-up CLs.

BASE=1209953002
BUG=505445
Committed: https://crrev.com/5a74892971ce9c5577c55608fbf3a73ce308768e
Cr-Commit-Position: refs/heads/master@{#340096}

[msramek, 2015-06-29 16:56:11]

msramek@chromium.org changed reviewers:
+ mkwst@chromium.org, vabr@chromium.org

[msramek, 2015-06-29 16:56:11]

Hi Mike and Václav,

after renaming avatar to icon in the credential manager (not landed yet), this
CL contains the next step to rename it in the PasswordForm. PTAL.

Thanks,
Martin

[Mike West, 2015-06-30 06:17:32]

LGTM.

[vabr (Chromium), 2015-06-30 12:52:34]

components/autofill/core/common/password_form.* LGTM

[msramek, 2015-06-30 14:38:06]

The CQ bit was checked by msramek@chromium.org

[msramek, 2015-06-30 14:38:23]

The CQ bit was unchecked by msramek@chromium.org

[msramek, 2015-06-30 14:58:54]

The CQ bit was checked by msramek@chromium.org

[msramek, 2015-06-30 14:58:54]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org,
mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/1220713005/#ps20001
(title: "Rebase.")

[commit-bot: I haz the power, 2015-06-30 14:59:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1220713005/20001

[commit-bot: I haz the power, 2015-06-30 15:08:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-30 15:08:59]

Exceeded global retry quota

[msramek, 2015-06-30 15:10:15]

The CQ bit was checked by msramek@chromium.org

[commit-bot: I haz the power, 2015-06-30 15:11:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1220713005/20001

[commit-bot: I haz the power, 2015-06-30 15:13:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-30 15:13:52]

Exceeded global retry quota

[msramek, 2015-07-01 10:07:02]

Added some missing occurrences. I need to compile these things with the target
"all"...

[vabr (Chromium), 2015-07-01 11:48:24]

Still LGTM.
Vaclav

[msramek, 2015-07-02 19:46:42]

msramek@chromium.org changed reviewers:
+ rohitrao@chromium.org, yfriedman@chromium.org

[msramek, 2015-07-02 19:46:43]

+yfriedman@ PTAL for ui/android
+rohitrao@ PTAL for ui/cocoa

[rohitrao (ping after 24h), 2015-07-09 11:56:03]

Cocoa LGTM

[msramek, 2015-07-17 12:52:47]

Yaron, friendly ping :)

[Yaron, 2015-07-17 14:20:24]

On 2015/07/17 12:52:47, msramek wrote:
> Yaron, friendly ping :)

lgtm

sorry about that - not sure how I missed it in my inbox :(

[msramek, 2015-07-22 13:45:20]

No worries :)

I rebased this to a fresh checkout and am going to land.

[msramek, 2015-07-22 13:45:26]

The CQ bit was checked by msramek@chromium.org

[msramek, 2015-07-22 13:45:26]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org,
vabr@chromium.org, yfriedman@chromium.org, rohitrao@chromium.org
Link to the patchset: https://codereview.chromium.org/1220713005/#ps180001
(title: "Rebased.")

[commit-bot: I haz the power, 2015-07-22 13:45:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1220713005/180001

[commit-bot: I haz the power, 2015-07-22 15:16:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-22 15:16:48]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[msramek, 2015-07-23 13:50:45]

The CQ bit was checked by msramek@chromium.org

[commit-bot: I haz the power, 2015-07-23 13:50:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1220713005/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1220713005/180001

[commit-bot: I haz the power, 2015-07-23 15:05:15]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2015-07-23 15:05:53]

Patchset 10 (id:??) landed as
https://crrev.com/5a74892971ce9c5577c55608fbf3a73ce308768e
Cr-Commit-Position: refs/heads/master@{#340096}