chrome/browser/ui/cocoa/passwords/credential_item_view.mm - Issue 1220713005: Rename avatar_url to icon_url in PasswordForm.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/passwords/credential_item_view.mm

Issue 1220713005: Rename avatar_url to icon_url in PasswordForm. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@rename2

Patch Set: Rebased. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/passwords/credential_item_view.mm

diff --git a/chrome/browser/ui/cocoa/passwords/credential_item_view.mm b/chrome/browser/ui/cocoa/passwords/credential_item_view.mm

index 3ca2de21aad8c41a38f40f69ca0f53035c951f79..2ab98a9cd75d193e4787e98931fb90d0f22af457 100644

--- a/chrome/browser/ui/cocoa/passwords/credential_item_view.mm

+++ b/chrome/browser/ui/cocoa/passwords/credential_item_view.mm

@@ -123,8 +123,8 @@ const CGFloat kVerticalPaddingBetweenLabels = 2.0f;

// Use a default avatar and fetch the custom one, if it exists.

[self updateAvatar:[[self class] defaultAvatar]];

- if (passwordForm_.avatar_url.is_valid())

- [delegate_ fetchAvatar:passwordForm_.avatar_url forView:self];

+ if (passwordForm_.icon_url.is_valid())

+ [delegate_ fetchAvatar:passwordForm_.icon_url forView:self];

// When resizing, stick to the left (resp. right for RTL) edge.

const NSUInteger autoresizingMask =