Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Side by Side Diff: chrome/browser/password_manager/native_backend_libsecret.cc

Issue 1220713005: Rename avatar_url to icon_url in PasswordForm. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@rename2
Patch Set: Rebased. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/password_manager/native_backend_libsecret.h" 5 #include "chrome/browser/password_manager/native_backend_libsecret.h"
6 6
7 #include <dlfcn.h> 7 #include <dlfcn.h>
8 #include <list> 8 #include <list>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 168 matching lines...) Expand 10 before | Expand all | Expand 10 after
179 static_cast<PasswordForm::Type>(GetUintFromAttributes(attrs, "type")); 179 static_cast<PasswordForm::Type>(GetUintFromAttributes(attrs, "type"));
180 form->times_used = GetUintFromAttributes(attrs, "times_used"); 180 form->times_used = GetUintFromAttributes(attrs, "times_used");
181 form->scheme = 181 form->scheme =
182 static_cast<PasswordForm::Scheme>(GetUintFromAttributes(attrs, "scheme")); 182 static_cast<PasswordForm::Scheme>(GetUintFromAttributes(attrs, "scheme"));
183 int64 date_synced = 0; 183 int64 date_synced = 0;
184 base::StringToInt64(GetStringFromAttributes(attrs, "date_synced"), 184 base::StringToInt64(GetStringFromAttributes(attrs, "date_synced"),
185 &date_synced); 185 &date_synced);
186 form->date_synced = base::Time::FromInternalValue(date_synced); 186 form->date_synced = base::Time::FromInternalValue(date_synced);
187 form->display_name = 187 form->display_name =
188 UTF8ToUTF16(GetStringFromAttributes(attrs, "display_name")); 188 UTF8ToUTF16(GetStringFromAttributes(attrs, "display_name"));
189 form->avatar_url = GURL(GetStringFromAttributes(attrs, "avatar_url")); 189 form->icon_url = GURL(GetStringFromAttributes(attrs, "avatar_url"));
190 form->federation_url = GURL(GetStringFromAttributes(attrs, "federation_url")); 190 form->federation_url = GURL(GetStringFromAttributes(attrs, "federation_url"));
191 form->skip_zero_click = GetUintFromAttributes(attrs, "skip_zero_click"); 191 form->skip_zero_click = GetUintFromAttributes(attrs, "skip_zero_click");
192 form->generation_upload_status = 192 form->generation_upload_status =
193 static_cast<PasswordForm::GenerationUploadStatus>( 193 static_cast<PasswordForm::GenerationUploadStatus>(
194 GetUintFromAttributes(attrs, "generation_upload_status")); 194 GetUintFromAttributes(attrs, "generation_upload_status"));
195 base::StringPiece encoded_form_data = 195 base::StringPiece encoded_form_data =
196 GetStringFromAttributes(attrs, "form_data"); 196 GetStringFromAttributes(attrs, "form_data");
197 if (!encoded_form_data.empty()) { 197 if (!encoded_form_data.empty()) {
198 bool success = DeserializeFormDataFromBase64String(encoded_form_data, 198 bool success = DeserializeFormDataFromBase64String(encoded_form_data,
199 &form->form_data); 199 &form->form_data);
(...skipping 248 matching lines...) Expand 10 before | Expand all | Expand 10 after
448 "signon_realm", form.signon_realm.c_str(), 448 "signon_realm", form.signon_realm.c_str(),
449 "ssl_valid", form.ssl_valid, 449 "ssl_valid", form.ssl_valid,
450 "preferred", form.preferred, 450 "preferred", form.preferred,
451 "date_created", base::Int64ToString(date_created).c_str(), 451 "date_created", base::Int64ToString(date_created).c_str(),
452 "blacklisted_by_user", form.blacklisted_by_user, 452 "blacklisted_by_user", form.blacklisted_by_user,
453 "type", form.type, 453 "type", form.type,
454 "times_used", form.times_used, 454 "times_used", form.times_used,
455 "scheme", form.scheme, 455 "scheme", form.scheme,
456 "date_synced", base::Int64ToString(date_synced).c_str(), 456 "date_synced", base::Int64ToString(date_synced).c_str(),
457 "display_name", UTF16ToUTF8(form.display_name).c_str(), 457 "display_name", UTF16ToUTF8(form.display_name).c_str(),
458 "avatar_url", form.avatar_url.spec().c_str(), 458 "avatar_url", form.icon_url.spec().c_str(),
459 "federation_url", form.federation_url.spec().c_str(), 459 "federation_url", form.federation_url.spec().c_str(),
460 "skip_zero_click", form.skip_zero_click, 460 "skip_zero_click", form.skip_zero_click,
461 "generation_upload_status", form.generation_upload_status, 461 "generation_upload_status", form.generation_upload_status,
462 "form_data", form_data.c_str(), 462 "form_data", form_data.c_str(),
463 "application", app_string_.c_str(), nullptr); 463 "application", app_string_.c_str(), nullptr);
464 464
465 if (error) { 465 if (error) {
466 VLOG(1) << "Libsecret add raw login failed: " << error->message; 466 VLOG(1) << "Libsecret add raw login failed: " << error->message;
467 g_error_free(error); 467 g_error_free(error);
468 return false; 468 return false;
(...skipping 145 matching lines...) Expand 10 before | Expand all | Expand 10 after
614 UMA_HISTOGRAM_ENUMERATION( 614 UMA_HISTOGRAM_ENUMERATION(
615 "PasswordManager.PslDomainMatchTriggering", 615 "PasswordManager.PslDomainMatchTriggering",
616 password_manager::ShouldPSLDomainMatchingApply(registered_domain) 616 password_manager::ShouldPSLDomainMatchingApply(registered_domain)
617 ? psl_domain_match_metric 617 ? psl_domain_match_metric
618 : password_manager::PSL_DOMAIN_MATCH_NOT_USED, 618 : password_manager::PSL_DOMAIN_MATCH_NOT_USED,
619 password_manager::PSL_DOMAIN_MATCH_COUNT); 619 password_manager::PSL_DOMAIN_MATCH_COUNT);
620 } 620 }
621 g_list_free(found); 621 g_list_free(found);
622 return forms.Pass(); 622 return forms.Pass();
623 } 623 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698