components/password_manager/core/browser/password_manager_test_utils.cc - Issue 1220713005: Rename avatar_url to icon_url in PasswordForm.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager_test_utils.cc

Issue 1220713005: Rename avatar_url to icon_url in PasswordForm. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@rename2

Patch Set: Rebased. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_manager_test_utils.h ('k') | components/password_manager/core/browser/password_syncable_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_manager_test_utils.cc

diff --git a/components/password_manager/core/browser/password_manager_test_utils.cc b/components/password_manager/core/browser/password_manager_test_utils.cc

index 74da854115cc087ead90b2b0b0530591073aa2d1..9613d23b87b765280e9449d2c57451f36bc91a5d 100644

--- a/components/password_manager/core/browser/password_manager_test_utils.cc

+++ b/components/password_manager/core/browser/password_manager_test_utils.cc

@@ -14,7 +14,7 @@ using autofill::PasswordForm;

namespace password_manager {

-const char kTestingAvatarUrlSpec[] = "https://accounts.google.com/Avatar";

+const char kTestingIconUrlSpec[] = "https://accounts.google.com/Icon";

const char kTestingFederationUrlSpec[] = "https://accounts.google.com/login";

const int kTestingDaysAfterPasswordsAreSynced = 1;

const wchar_t kTestingFederatedLoginMarker[] = L"__federated__";

@@ -54,7 +54,7 @@ scoped_ptr<PasswordForm> CreatePasswordFormFromDataForTesting(

} else {

form->blacklisted_by_user = true;

}

- form->avatar_url = GURL(kTestingAvatarUrlSpec);

+ form->icon_url = GURL(kTestingIconUrlSpec);

return form.Pass();

}