Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Unified Diff: components/password_manager/core/browser/password_syncable_service_unittest.cc

Issue 1220713005: Rename avatar_url to icon_url in PasswordForm. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@rename2
Patch Set: Rebased. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_syncable_service_unittest.cc
diff --git a/components/password_manager/core/browser/password_syncable_service_unittest.cc b/components/password_manager/core/browser/password_syncable_service_unittest.cc
index 3f7b3033751246ba321495efe444a594885c0315..abd13a83398fd2c7d6004b7716f73e4d170ecfa6 100644
--- a/components/password_manager/core/browser/password_syncable_service_unittest.cc
+++ b/components/password_manager/core/browser/password_syncable_service_unittest.cc
@@ -51,7 +51,7 @@ namespace {
// PasswordForm values for tests.
const autofill::PasswordForm::Type kArbitraryType =
autofill::PasswordForm::TYPE_GENERATED;
-const char kAvatarUrl[] = "https://fb.com/Avatar";
+const char kIconUrl[] = "https://fb.com/Icon";
const char kDisplayName[] = "Agent Smith";
const char kFederationUrl[] = "https://fb.com/federation_url";
const char kPassword[] = "abcdef";
@@ -133,7 +133,7 @@ SyncData CreateSyncData(const std::string& signon_realm) {
password_specifics->set_type(autofill::PasswordForm::TYPE_GENERATED);
password_specifics->set_times_used(3);
password_specifics->set_display_name("Mr. X");
- password_specifics->set_avatar_url("https://accounts.google.com/Avatar");
+ password_specifics->set_avatar_url("https://accounts.google.com/Icon");
password_specifics->set_federation_url("https://google.com/federation");
password_specifics->set_username_value("kingkong");
password_specifics->set_password_value("sicrit");
@@ -282,7 +282,7 @@ TEST_F(PasswordSyncableServiceTest, AdditionOnlyInPasswordStore) {
form.times_used = kTimesUsed;
form.type = kArbitraryType;
form.display_name = base::ASCIIToUTF16(kDisplayName);
- form.avatar_url = GURL(kAvatarUrl);
+ form.icon_url = GURL(kIconUrl);
form.federation_url = GURL(kFederationUrl);
form.username_value = base::ASCIIToUTF16(kUsername);
form.password_value = base::ASCIIToUTF16(kPassword);
@@ -422,7 +422,7 @@ TEST_F(PasswordSyncableServiceTest, GetAllSyncData) {
form1.times_used = kTimesUsed;
form1.type = kArbitraryType;
form1.display_name = base::ASCIIToUTF16(kDisplayName);
- form1.avatar_url = GURL(kAvatarUrl);
+ form1.icon_url = GURL(kIconUrl);
form1.federation_url = GURL(kFederationUrl);
form1.username_value = base::ASCIIToUTF16(kUsername);
form1.password_value = base::ASCIIToUTF16(kPassword);

Powered by Google App Engine
This is Rietveld 408576698