Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Unified Diff: components/password_manager/core/browser/login_database.cc

Issue 1220713005: Rename avatar_url to icon_url in PasswordForm. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@rename2
Patch Set: Rebased. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/login_database.cc
diff --git a/components/password_manager/core/browser/login_database.cc b/components/password_manager/core/browser/login_database.cc
index 4ab709a180ada8afe5f047d39c7eab3c5afb9c7d..261f481fd6312ae5b3bd2dd49c663c6082b36f15 100644
--- a/components/password_manager/core/browser/login_database.cc
+++ b/components/password_manager/core/browser/login_database.cc
@@ -112,7 +112,7 @@ void BindAddStatement(const PasswordForm& form,
form_data_pickle.size());
s->BindInt64(COLUMN_DATE_SYNCED, form.date_synced.ToInternalValue());
s->BindString16(COLUMN_DISPLAY_NAME, form.display_name);
- s->BindString(COLUMN_AVATAR_URL, form.avatar_url.spec());
+ s->BindString(COLUMN_AVATAR_URL, form.icon_url.spec());
s->BindString(COLUMN_FEDERATION_URL, form.federation_url.spec());
s->BindInt(COLUMN_SKIP_ZERO_CLICK, form.skip_zero_click);
s->BindInt(COLUMN_GENERATION_UPLOAD_STATUS, form.generation_upload_status);
@@ -653,7 +653,7 @@ PasswordStoreChangeList LoginDatabase::UpdateLogin(const PasswordForm& form) {
s.BindInt(10, form.scheme);
s.BindInt(11, form.type);
s.BindString16(12, form.display_name);
- s.BindString(13, form.avatar_url.spec());
+ s.BindString(13, form.icon_url.spec());
s.BindString(14, form.federation_url.spec());
s.BindInt(15, form.skip_zero_click);
s.BindInt(16, form.generation_upload_status);
@@ -781,7 +781,7 @@ LoginDatabase::EncryptionResult LoginDatabase::InitPasswordFormFromStatement(
form->date_synced =
base::Time::FromInternalValue(s.ColumnInt64(COLUMN_DATE_SYNCED));
form->display_name = s.ColumnString16(COLUMN_DISPLAY_NAME);
- form->avatar_url = GURL(s.ColumnString(COLUMN_AVATAR_URL));
+ form->icon_url = GURL(s.ColumnString(COLUMN_AVATAR_URL));
form->federation_url = GURL(s.ColumnString(COLUMN_FEDERATION_URL));
form->skip_zero_click = (s.ColumnInt(COLUMN_SKIP_ZERO_CLICK) > 0);
int generation_upload_status_int =
« no previous file with comments | « components/autofill/core/common/password_form.cc ('k') | components/password_manager/core/browser/login_database_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698