chrome/browser/password_manager/native_backend_gnome_x_unittest.cc - Issue 1220713005: Rename avatar_url to icon_url in PasswordForm.

Unified Diff: chrome/browser/password_manager/native_backend_gnome_x_unittest.cc

Issue 1220713005: Rename avatar_url to icon_url in PasswordForm. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@rename2

Patch Set: Rebased. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/native_backend_gnome_x.cc ('k') | chrome/browser/password_manager/native_backend_kwallet_x.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/native_backend_gnome_x_unittest.cc

diff --git a/chrome/browser/password_manager/native_backend_gnome_x_unittest.cc b/chrome/browser/password_manager/native_backend_gnome_x_unittest.cc

index 246e037a512b3f3545b77ae3a9371868503d39b8..2338ad91af35d468da3417cf4ae064252bb37298 100644

--- a/chrome/browser/password_manager/native_backend_gnome_x_unittest.cc

+++ b/chrome/browser/password_manager/native_backend_gnome_x_unittest.cc

@@ -308,7 +308,7 @@ void CheckPasswordChanges(const PasswordStoreChangeList& expected_list,

EXPECT_EQ(expected.scheme, actual.scheme);

EXPECT_EQ(expected.date_synced, actual.date_synced);

EXPECT_EQ(expected.display_name, actual.display_name);

- EXPECT_EQ(expected.avatar_url, actual.avatar_url);

+ EXPECT_EQ(expected.icon_url, actual.icon_url);

EXPECT_EQ(expected.federation_url, actual.federation_url);

EXPECT_EQ(expected.skip_zero_click, actual.skip_zero_click);

EXPECT_EQ(expected.generation_upload_status,

@@ -358,7 +358,7 @@ class NativeBackendGnomeTest : public testing::Test {

form_google_.date_created = base::Time::Now();

form_google_.date_synced = base::Time::Now();

form_google_.display_name = UTF8ToUTF16("Joe Schmoe");

- form_google_.avatar_url = GURL("http://www.google.com/avatar");

+ form_google_.icon_url = GURL("http://www.google.com/icon");

form_google_.federation_url = GURL("http://www.google.com/federation_url");

form_google_.skip_zero_click = true;

form_google_.generation_upload_status = PasswordForm::POSITIVE_SIGNAL_SENT;

@@ -375,7 +375,7 @@ class NativeBackendGnomeTest : public testing::Test {

form_facebook_.date_created = base::Time::Now();

form_facebook_.date_synced = base::Time::Now();

form_facebook_.display_name = UTF8ToUTF16("Joe Schmoe");

- form_facebook_.avatar_url = GURL("http://www.facebook.com/avatar");

+ form_facebook_.icon_url = GURL("http://www.facebook.com/icon");

form_facebook_.federation_url = GURL("http://www.facebook.com/federation");

form_facebook_.skip_zero_click = true;

form_facebook_.generation_upload_status = PasswordForm::NO_SIGNAL_SENT;

@@ -474,7 +474,7 @@ class NativeBackendGnomeTest : public testing::Test {

CheckStringAttribute(item, "date_synced", base::Int64ToString(

form.date_synced.ToInternalValue()));

CheckStringAttribute(item, "display_name", UTF16ToUTF8(form.display_name));

- CheckStringAttribute(item, "avatar_url", form.avatar_url.spec());

+ CheckStringAttribute(item, "avatar_url", form.icon_url.spec());

CheckStringAttribute(item, "federation_url", form.federation_url.spec());

CheckUint32Attribute(item, "skip_zero_click", form.skip_zero_click);

CheckUint32Attribute(item, "generation_upload_status",