Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2529)

Unified Diff: chrome/browser/password_manager/native_backend_libsecret.cc

Issue 1220713005: Rename avatar_url to icon_url in PasswordForm. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@rename2
Patch Set: Rebased. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/native_backend_libsecret.cc
diff --git a/chrome/browser/password_manager/native_backend_libsecret.cc b/chrome/browser/password_manager/native_backend_libsecret.cc
index 252af3d813ce097c9202f0a56151ca497734440a..e6cc35af8120b932a9a676ee186c4ac4875501d8 100644
--- a/chrome/browser/password_manager/native_backend_libsecret.cc
+++ b/chrome/browser/password_manager/native_backend_libsecret.cc
@@ -186,7 +186,7 @@ scoped_ptr<PasswordForm> FormOutOfAttributes(GHashTable* attrs) {
form->date_synced = base::Time::FromInternalValue(date_synced);
form->display_name =
UTF8ToUTF16(GetStringFromAttributes(attrs, "display_name"));
- form->avatar_url = GURL(GetStringFromAttributes(attrs, "avatar_url"));
+ form->icon_url = GURL(GetStringFromAttributes(attrs, "avatar_url"));
form->federation_url = GURL(GetStringFromAttributes(attrs, "federation_url"));
form->skip_zero_click = GetUintFromAttributes(attrs, "skip_zero_click");
form->generation_upload_status =
@@ -455,7 +455,7 @@ bool NativeBackendLibsecret::RawAddLogin(const PasswordForm& form) {
"scheme", form.scheme,
"date_synced", base::Int64ToString(date_synced).c_str(),
"display_name", UTF16ToUTF8(form.display_name).c_str(),
- "avatar_url", form.avatar_url.spec().c_str(),
+ "avatar_url", form.icon_url.spec().c_str(),
"federation_url", form.federation_url.spec().c_str(),
"skip_zero_click", form.skip_zero_click,
"generation_upload_status", form.generation_upload_status,

Powered by Google App Engine
This is Rietveld 408576698