Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(879)

Side by Side Diff: chrome/browser/password_manager/native_backend_gnome_x.cc

Issue 1220713005: Rename avatar_url to icon_url in PasswordForm. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@rename2
Patch Set: Rebased. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/password_manager/native_backend_gnome_x_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/password_manager/native_backend_gnome_x.h" 5 #include "chrome/browser/password_manager/native_backend_gnome_x.h"
6 6
7 #include <dlfcn.h> 7 #include <dlfcn.h>
8 #include <gnome-keyring.h> 8 #include <gnome-keyring.h>
9 9
10 #include <map> 10 #include <map>
(...skipping 136 matching lines...) Expand 10 before | Expand all | Expand 10 after
147 ? base::Time::FromTimeT(date_created) 147 ? base::Time::FromTimeT(date_created)
148 : base::Time::FromInternalValue(date_created); 148 : base::Time::FromInternalValue(date_created);
149 form->blacklisted_by_user = uint_attr_map["blacklisted_by_user"]; 149 form->blacklisted_by_user = uint_attr_map["blacklisted_by_user"];
150 form->type = static_cast<PasswordForm::Type>(uint_attr_map["type"]); 150 form->type = static_cast<PasswordForm::Type>(uint_attr_map["type"]);
151 form->times_used = uint_attr_map["times_used"]; 151 form->times_used = uint_attr_map["times_used"];
152 form->scheme = static_cast<PasswordForm::Scheme>(uint_attr_map["scheme"]); 152 form->scheme = static_cast<PasswordForm::Scheme>(uint_attr_map["scheme"]);
153 int64 date_synced = 0; 153 int64 date_synced = 0;
154 base::StringToInt64(string_attr_map["date_synced"], &date_synced); 154 base::StringToInt64(string_attr_map["date_synced"], &date_synced);
155 form->date_synced = base::Time::FromInternalValue(date_synced); 155 form->date_synced = base::Time::FromInternalValue(date_synced);
156 form->display_name = UTF8ToUTF16(string_attr_map["display_name"]); 156 form->display_name = UTF8ToUTF16(string_attr_map["display_name"]);
157 form->avatar_url = GURL(string_attr_map["avatar_url"]); 157 form->icon_url = GURL(string_attr_map["avatar_url"]);
158 form->federation_url = GURL(string_attr_map["federation_url"]); 158 form->federation_url = GURL(string_attr_map["federation_url"]);
159 form->skip_zero_click = uint_attr_map["skip_zero_click"]; 159 form->skip_zero_click = uint_attr_map["skip_zero_click"];
160 form->generation_upload_status = 160 form->generation_upload_status =
161 static_cast<PasswordForm::GenerationUploadStatus>( 161 static_cast<PasswordForm::GenerationUploadStatus>(
162 uint_attr_map["generation_upload_status"]); 162 uint_attr_map["generation_upload_status"]);
163 if (!string_attr_map["form_data"].empty()) { 163 if (!string_attr_map["form_data"].empty()) {
164 bool success = DeserializeFormDataFromBase64String( 164 bool success = DeserializeFormDataFromBase64String(
165 string_attr_map["form_data"], &form->form_data); 165 string_attr_map["form_data"], &form->form_data);
166 FormDeserializationStatus status = success ? GNOME_SUCCESS : GNOME_FAILURE; 166 FormDeserializationStatus status = success ? GNOME_SUCCESS : GNOME_FAILURE;
167 LogFormDataDeserializationStatus(status); 167 LogFormDataDeserializationStatus(status);
(...skipping 195 matching lines...) Expand 10 before | Expand all | Expand 10 after
363 "signon_realm", form.signon_realm.c_str(), 363 "signon_realm", form.signon_realm.c_str(),
364 "ssl_valid", form.ssl_valid, 364 "ssl_valid", form.ssl_valid,
365 "preferred", form.preferred, 365 "preferred", form.preferred,
366 "date_created", base::Int64ToString(date_created).c_str(), 366 "date_created", base::Int64ToString(date_created).c_str(),
367 "blacklisted_by_user", form.blacklisted_by_user, 367 "blacklisted_by_user", form.blacklisted_by_user,
368 "type", form.type, 368 "type", form.type,
369 "times_used", form.times_used, 369 "times_used", form.times_used,
370 "scheme", form.scheme, 370 "scheme", form.scheme,
371 "date_synced", base::Int64ToString(date_synced).c_str(), 371 "date_synced", base::Int64ToString(date_synced).c_str(),
372 "display_name", UTF16ToUTF8(form.display_name).c_str(), 372 "display_name", UTF16ToUTF8(form.display_name).c_str(),
373 "avatar_url", form.avatar_url.spec().c_str(), 373 "avatar_url", form.icon_url.spec().c_str(),
374 "federation_url", form.federation_url.spec().c_str(), 374 "federation_url", form.federation_url.spec().c_str(),
375 "skip_zero_click", form.skip_zero_click, 375 "skip_zero_click", form.skip_zero_click,
376 "generation_upload_status", form.generation_upload_status, 376 "generation_upload_status", form.generation_upload_status,
377 "form_data", form_data.c_str(), 377 "form_data", form_data.c_str(),
378 "application", app_string, 378 "application", app_string,
379 nullptr); 379 nullptr);
380 } 380 }
381 381
382 void GKRMethod::AddLoginSearch(const PasswordForm& form, 382 void GKRMethod::AddLoginSearch(const PasswordForm& form,
383 const char* app_string) { 383 const char* app_string) {
(...skipping 419 matching lines...) Expand 10 before | Expand all | Expand 10 after
803 for (size_t i = 0; i < forms.size(); ++i) { 803 for (size_t i = 0; i < forms.size(); ++i) {
804 if (RemoveLogin(*forms[i])) { 804 if (RemoveLogin(*forms[i])) {
805 changes->push_back(password_manager::PasswordStoreChange( 805 changes->push_back(password_manager::PasswordStoreChange(
806 password_manager::PasswordStoreChange::REMOVE, *forms[i])); 806 password_manager::PasswordStoreChange::REMOVE, *forms[i]));
807 } else { 807 } else {
808 ok = false; 808 ok = false;
809 } 809 }
810 } 810 }
811 return ok; 811 return ok;
812 } 812 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/password_manager/native_backend_gnome_x_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698