Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Side by Side Diff: chrome/browser/password_manager/native_backend_libsecret_unittest.cc

Issue 1220713005: Rename avatar_url to icon_url in PasswordForm. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@rename2
Patch Set: Rebased. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stdarg.h> 5 #include <stdarg.h>
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/location.h" 8 #include "base/location.h"
9 #include "base/prefs/pref_service.h" 9 #include "base/prefs/pref_service.h"
10 #include "base/single_thread_task_runner.h" 10 #include "base/single_thread_task_runner.h"
(...skipping 225 matching lines...) Expand 10 before | Expand all | Expand 10 after
236 EXPECT_EQ(expected.signon_realm, actual.signon_realm); 236 EXPECT_EQ(expected.signon_realm, actual.signon_realm);
237 EXPECT_EQ(expected.ssl_valid, actual.ssl_valid); 237 EXPECT_EQ(expected.ssl_valid, actual.ssl_valid);
238 EXPECT_EQ(expected.preferred, actual.preferred); 238 EXPECT_EQ(expected.preferred, actual.preferred);
239 EXPECT_EQ(expected.date_created, actual.date_created); 239 EXPECT_EQ(expected.date_created, actual.date_created);
240 EXPECT_EQ(expected.blacklisted_by_user, actual.blacklisted_by_user); 240 EXPECT_EQ(expected.blacklisted_by_user, actual.blacklisted_by_user);
241 EXPECT_EQ(expected.type, actual.type); 241 EXPECT_EQ(expected.type, actual.type);
242 EXPECT_EQ(expected.times_used, actual.times_used); 242 EXPECT_EQ(expected.times_used, actual.times_used);
243 EXPECT_EQ(expected.scheme, actual.scheme); 243 EXPECT_EQ(expected.scheme, actual.scheme);
244 EXPECT_EQ(expected.date_synced, actual.date_synced); 244 EXPECT_EQ(expected.date_synced, actual.date_synced);
245 EXPECT_EQ(expected.display_name, actual.display_name); 245 EXPECT_EQ(expected.display_name, actual.display_name);
246 EXPECT_EQ(expected.avatar_url, actual.avatar_url); 246 EXPECT_EQ(expected.icon_url, actual.icon_url);
247 EXPECT_EQ(expected.federation_url, actual.federation_url); 247 EXPECT_EQ(expected.federation_url, actual.federation_url);
248 EXPECT_EQ(expected.skip_zero_click, actual.skip_zero_click); 248 EXPECT_EQ(expected.skip_zero_click, actual.skip_zero_click);
249 EXPECT_EQ(expected.generation_upload_status, 249 EXPECT_EQ(expected.generation_upload_status,
250 actual.generation_upload_status); 250 actual.generation_upload_status);
251 } 251 }
252 } 252 }
253 253
254 } // anonymous namespace 254 } // anonymous namespace
255 255
256 class NativeBackendLibsecretTest : public testing::Test { 256 class NativeBackendLibsecretTest : public testing::Test {
(...skipping 20 matching lines...) Expand all
277 form_google_.username_element = UTF8ToUTF16("user"); 277 form_google_.username_element = UTF8ToUTF16("user");
278 form_google_.username_value = UTF8ToUTF16("joeschmoe"); 278 form_google_.username_value = UTF8ToUTF16("joeschmoe");
279 form_google_.password_element = UTF8ToUTF16("pass"); 279 form_google_.password_element = UTF8ToUTF16("pass");
280 form_google_.password_value = UTF8ToUTF16("seekrit"); 280 form_google_.password_value = UTF8ToUTF16("seekrit");
281 form_google_.submit_element = UTF8ToUTF16("submit"); 281 form_google_.submit_element = UTF8ToUTF16("submit");
282 form_google_.signon_realm = "http://www.google.com/"; 282 form_google_.signon_realm = "http://www.google.com/";
283 form_google_.type = PasswordForm::TYPE_GENERATED; 283 form_google_.type = PasswordForm::TYPE_GENERATED;
284 form_google_.date_created = base::Time::Now(); 284 form_google_.date_created = base::Time::Now();
285 form_google_.date_synced = base::Time::Now(); 285 form_google_.date_synced = base::Time::Now();
286 form_google_.display_name = UTF8ToUTF16("Joe Schmoe"); 286 form_google_.display_name = UTF8ToUTF16("Joe Schmoe");
287 form_google_.avatar_url = GURL("http://www.google.com/avatar"); 287 form_google_.icon_url = GURL("http://www.google.com/icon");
288 form_google_.federation_url = GURL("http://www.google.com/federation_url"); 288 form_google_.federation_url = GURL("http://www.google.com/federation_url");
289 form_google_.skip_zero_click = true; 289 form_google_.skip_zero_click = true;
290 form_google_.generation_upload_status = PasswordForm::POSITIVE_SIGNAL_SENT; 290 form_google_.generation_upload_status = PasswordForm::POSITIVE_SIGNAL_SENT;
291 form_google_.form_data.name = UTF8ToUTF16("form_name"); 291 form_google_.form_data.name = UTF8ToUTF16("form_name");
292 292
293 form_facebook_.origin = GURL("http://www.facebook.com/"); 293 form_facebook_.origin = GURL("http://www.facebook.com/");
294 form_facebook_.action = GURL("http://www.facebook.com/login"); 294 form_facebook_.action = GURL("http://www.facebook.com/login");
295 form_facebook_.username_element = UTF8ToUTF16("user"); 295 form_facebook_.username_element = UTF8ToUTF16("user");
296 form_facebook_.username_value = UTF8ToUTF16("a"); 296 form_facebook_.username_value = UTF8ToUTF16("a");
297 form_facebook_.password_element = UTF8ToUTF16("password"); 297 form_facebook_.password_element = UTF8ToUTF16("password");
298 form_facebook_.password_value = UTF8ToUTF16("b"); 298 form_facebook_.password_value = UTF8ToUTF16("b");
299 form_facebook_.submit_element = UTF8ToUTF16("submit"); 299 form_facebook_.submit_element = UTF8ToUTF16("submit");
300 form_facebook_.signon_realm = "http://www.facebook.com/"; 300 form_facebook_.signon_realm = "http://www.facebook.com/";
301 form_facebook_.date_created = base::Time::Now(); 301 form_facebook_.date_created = base::Time::Now();
302 form_facebook_.date_synced = base::Time::Now(); 302 form_facebook_.date_synced = base::Time::Now();
303 form_facebook_.display_name = UTF8ToUTF16("Joe Schmoe"); 303 form_facebook_.display_name = UTF8ToUTF16("Joe Schmoe");
304 form_facebook_.avatar_url = GURL("http://www.facebook.com/avatar"); 304 form_facebook_.icon_url = GURL("http://www.facebook.com/icon");
305 form_facebook_.federation_url = GURL("http://www.facebook.com/federation"); 305 form_facebook_.federation_url = GURL("http://www.facebook.com/federation");
306 form_facebook_.skip_zero_click = true; 306 form_facebook_.skip_zero_click = true;
307 form_facebook_.generation_upload_status = PasswordForm::NO_SIGNAL_SENT; 307 form_facebook_.generation_upload_status = PasswordForm::NO_SIGNAL_SENT;
308 308
309 form_isc_.origin = GURL("http://www.isc.org/"); 309 form_isc_.origin = GURL("http://www.isc.org/");
310 form_isc_.action = GURL("http://www.isc.org/auth"); 310 form_isc_.action = GURL("http://www.isc.org/auth");
311 form_isc_.username_element = UTF8ToUTF16("id"); 311 form_isc_.username_element = UTF8ToUTF16("id");
312 form_isc_.username_value = UTF8ToUTF16("janedoe"); 312 form_isc_.username_value = UTF8ToUTF16("janedoe");
313 form_isc_.password_element = UTF8ToUTF16("passwd"); 313 form_isc_.password_element = UTF8ToUTF16("passwd");
314 form_isc_.password_value = UTF8ToUTF16("ihazabukkit"); 314 form_isc_.password_value = UTF8ToUTF16("ihazabukkit");
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
380 CheckUint32Attribute(item, "preferred", form.preferred); 380 CheckUint32Attribute(item, "preferred", form.preferred);
381 // We don't check the date created. It varies. 381 // We don't check the date created. It varies.
382 CheckUint32Attribute(item, "blacklisted_by_user", form.blacklisted_by_user); 382 CheckUint32Attribute(item, "blacklisted_by_user", form.blacklisted_by_user);
383 CheckUint32Attribute(item, "type", form.type); 383 CheckUint32Attribute(item, "type", form.type);
384 CheckUint32Attribute(item, "times_used", form.times_used); 384 CheckUint32Attribute(item, "times_used", form.times_used);
385 CheckUint32Attribute(item, "scheme", form.scheme); 385 CheckUint32Attribute(item, "scheme", form.scheme);
386 CheckStringAttribute( 386 CheckStringAttribute(
387 item, "date_synced", 387 item, "date_synced",
388 base::Int64ToString(form.date_synced.ToInternalValue())); 388 base::Int64ToString(form.date_synced.ToInternalValue()));
389 CheckStringAttribute(item, "display_name", UTF16ToUTF8(form.display_name)); 389 CheckStringAttribute(item, "display_name", UTF16ToUTF8(form.display_name));
390 CheckStringAttribute(item, "avatar_url", form.avatar_url.spec()); 390 CheckStringAttribute(item, "avatar_url", form.icon_url.spec());
391 CheckStringAttribute(item, "federation_url", form.federation_url.spec()); 391 CheckStringAttribute(item, "federation_url", form.federation_url.spec());
392 CheckUint32Attribute(item, "skip_zero_click", form.skip_zero_click); 392 CheckUint32Attribute(item, "skip_zero_click", form.skip_zero_click);
393 CheckUint32Attribute(item, "generation_upload_status", 393 CheckUint32Attribute(item, "generation_upload_status",
394 form.generation_upload_status); 394 form.generation_upload_status);
395 CheckStringAttribute(item, "application", app_string); 395 CheckStringAttribute(item, "application", app_string);
396 autofill::FormData actual; 396 autofill::FormData actual;
397 DeserializeFormDataFromBase64String( 397 DeserializeFormDataFromBase64String(
398 static_cast<char*>(g_hash_table_lookup(item->attributes, "form_data")), 398 static_cast<char*>(g_hash_table_lookup(item->attributes, "form_data")),
399 &actual); 399 &actual);
400 EXPECT_TRUE(form.form_data.SameFormAs(actual)); 400 EXPECT_TRUE(form.form_data.SameFormAs(actual));
(...skipping 440 matching lines...) Expand 10 before | Expand all | Expand 10 after
841 EXPECT_EQ(1u, global_mock_libsecret_items->size()); 841 EXPECT_EQ(1u, global_mock_libsecret_items->size());
842 // Remove a string attribute. 842 // Remove a string attribute.
843 (*global_mock_libsecret_items)[0]->RemoveAttribute("avatar_url"); 843 (*global_mock_libsecret_items)[0]->RemoveAttribute("avatar_url");
844 // Remove an integer attribute. 844 // Remove an integer attribute.
845 (*global_mock_libsecret_items)[0]->RemoveAttribute("ssl_valid"); 845 (*global_mock_libsecret_items)[0]->RemoveAttribute("ssl_valid");
846 846
847 ScopedVector<autofill::PasswordForm> form_list; 847 ScopedVector<autofill::PasswordForm> form_list;
848 backend.GetAutofillableLogins(&form_list); 848 backend.GetAutofillableLogins(&form_list);
849 849
850 EXPECT_EQ(1u, form_list.size()); 850 EXPECT_EQ(1u, form_list.size());
851 EXPECT_EQ(GURL(""), form_list[0]->avatar_url); 851 EXPECT_EQ(GURL(""), form_list[0]->icon_url);
852 EXPECT_FALSE(form_list[0]->ssl_valid); 852 EXPECT_FALSE(form_list[0]->ssl_valid);
853 } 853 }
854 854
855 // TODO(mdm): add more basic tests here at some point. 855 // TODO(mdm): add more basic tests here at some point.
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698