Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(978)

Unified Diff: chrome/browser/ui/cocoa/passwords/credential_item_view_unittest.mm

Issue 1220713005: Rename avatar_url to icon_url in PasswordForm. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@rename2
Patch Set: Rebased. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/passwords/credential_item_view_unittest.mm
diff --git a/chrome/browser/ui/cocoa/passwords/credential_item_view_unittest.mm b/chrome/browser/ui/cocoa/passwords/credential_item_view_unittest.mm
index a5057dd3398d99cedcfd6a5de14dfb85456e6d42..8845b8fa5b15aeb33c2df684b765fe354714c45c 100644
--- a/chrome/browser/ui/cocoa/passwords/credential_item_view_unittest.mm
+++ b/chrome/browser/ui/cocoa/passwords/credential_item_view_unittest.mm
@@ -85,7 +85,7 @@ autofill::PasswordForm CredentialWithName() {
autofill::PasswordForm CredentialWithAvatar() {
autofill::PasswordForm credential;
credential.username_value = base::ASCIIToUTF16("sandwich");
- credential.avatar_url = GURL("http://sandwich.com/pastrami.jpg");
+ credential.icon_url = GURL("http://sandwich.com/pastrami.jpg");
return credential;
}
@@ -94,7 +94,7 @@ autofill::PasswordForm CredentialWithNameAndAvatar() {
autofill::PasswordForm credential;
credential.username_value = base::ASCIIToUTF16("noodle");
credential.display_name = base::ASCIIToUTF16("pasta amatriciana");
- credential.avatar_url = GURL("http://pasta.com/amatriciana.png");
+ credential.icon_url = GURL("http://pasta.com/amatriciana.png");
return credential;
}
@@ -156,7 +156,7 @@ TEST_F(CredentialItemViewTest, CredentialWithAvatar) {
[item upperLabel].stringValue);
EXPECT_EQ(nil, [item lowerLabel]);
EXPECT_TRUE([delegate() didFetchAvatar]);
- EXPECT_EQ(form.avatar_url, [delegate() fetchedAvatarURL]);
+ EXPECT_EQ(form.icon_url, [delegate() fetchedAvatarURL]);
EXPECT_EQ(item, [delegate() viewForFetchedAvatar]);
EXPECT_TRUE(
ImagesEqual([CredentialItemView defaultAvatar], [item avatarView].image));
@@ -174,7 +174,7 @@ TEST_F(CredentialItemViewTest, CredentialWithNameAndAvatar) {
EXPECT_NSEQ(base::SysUTF16ToNSString(form.username_value),
[item lowerLabel].stringValue);
EXPECT_TRUE([delegate() didFetchAvatar]);
- EXPECT_EQ(form.avatar_url, [delegate() fetchedAvatarURL]);
+ EXPECT_EQ(form.icon_url, [delegate() fetchedAvatarURL]);
EXPECT_EQ(item, [delegate() viewForFetchedAvatar]);
EXPECT_TRUE(
ImagesEqual([CredentialItemView defaultAvatar], [item avatarView].image));

Powered by Google App Engine
This is Rietveld 408576698