Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Side by Side Diff: chrome/browser/ui/cocoa/passwords/credential_item_view_unittest.mm

Issue 1220713005: Rename avatar_url to icon_url in PasswordForm. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@rename2
Patch Set: Rebased. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "chrome/browser/ui/cocoa/passwords/credential_item_view.h" 5 #import "chrome/browser/ui/cocoa/passwords/credential_item_view.h"
6 6
7 #include "base/strings/sys_string_conversions.h" 7 #include "base/strings/sys_string_conversions.h"
8 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
9 #include "chrome/browser/ui/cocoa/cocoa_test_helper.h" 9 #include "chrome/browser/ui/cocoa/cocoa_test_helper.h"
10 #include "testing/gtest_mac.h" 10 #include "testing/gtest_mac.h"
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 autofill::PasswordForm credential; 78 autofill::PasswordForm credential;
79 credential.username_value = base::ASCIIToUTF16("pizza"); 79 credential.username_value = base::ASCIIToUTF16("pizza");
80 credential.display_name = base::ASCIIToUTF16("margherita pizza"); 80 credential.display_name = base::ASCIIToUTF16("margherita pizza");
81 return credential; 81 return credential;
82 } 82 }
83 83
84 // Returns a PasswordForm with a username and avatar URL. 84 // Returns a PasswordForm with a username and avatar URL.
85 autofill::PasswordForm CredentialWithAvatar() { 85 autofill::PasswordForm CredentialWithAvatar() {
86 autofill::PasswordForm credential; 86 autofill::PasswordForm credential;
87 credential.username_value = base::ASCIIToUTF16("sandwich"); 87 credential.username_value = base::ASCIIToUTF16("sandwich");
88 credential.avatar_url = GURL("http://sandwich.com/pastrami.jpg"); 88 credential.icon_url = GURL("http://sandwich.com/pastrami.jpg");
89 return credential; 89 return credential;
90 } 90 }
91 91
92 // Returns a PasswordForm with a username, display name, and avatar URL. 92 // Returns a PasswordForm with a username, display name, and avatar URL.
93 autofill::PasswordForm CredentialWithNameAndAvatar() { 93 autofill::PasswordForm CredentialWithNameAndAvatar() {
94 autofill::PasswordForm credential; 94 autofill::PasswordForm credential;
95 credential.username_value = base::ASCIIToUTF16("noodle"); 95 credential.username_value = base::ASCIIToUTF16("noodle");
96 credential.display_name = base::ASCIIToUTF16("pasta amatriciana"); 96 credential.display_name = base::ASCIIToUTF16("pasta amatriciana");
97 credential.avatar_url = GURL("http://pasta.com/amatriciana.png"); 97 credential.icon_url = GURL("http://pasta.com/amatriciana.png");
98 return credential; 98 return credential;
99 } 99 }
100 100
101 // Tests for CredentialItemViewTest. 101 // Tests for CredentialItemViewTest.
102 class CredentialItemViewTest : public CocoaTest { 102 class CredentialItemViewTest : public CocoaTest {
103 protected: 103 protected:
104 void SetUp() override { 104 void SetUp() override {
105 delegate_.reset([[CredentialItemTestDelegate alloc] init]); 105 delegate_.reset([[CredentialItemTestDelegate alloc] init]);
106 } 106 }
107 107
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
149 } 149 }
150 150
151 TEST_F(CredentialItemViewTest, CredentialWithAvatar) { 151 TEST_F(CredentialItemViewTest, CredentialWithAvatar) {
152 autofill::PasswordForm form(CredentialWithAvatar()); 152 autofill::PasswordForm form(CredentialWithAvatar());
153 CredentialItemView* item = view(form); 153 CredentialItemView* item = view(form);
154 154
155 EXPECT_NSEQ(base::SysUTF16ToNSString(form.username_value), 155 EXPECT_NSEQ(base::SysUTF16ToNSString(form.username_value),
156 [item upperLabel].stringValue); 156 [item upperLabel].stringValue);
157 EXPECT_EQ(nil, [item lowerLabel]); 157 EXPECT_EQ(nil, [item lowerLabel]);
158 EXPECT_TRUE([delegate() didFetchAvatar]); 158 EXPECT_TRUE([delegate() didFetchAvatar]);
159 EXPECT_EQ(form.avatar_url, [delegate() fetchedAvatarURL]); 159 EXPECT_EQ(form.icon_url, [delegate() fetchedAvatarURL]);
160 EXPECT_EQ(item, [delegate() viewForFetchedAvatar]); 160 EXPECT_EQ(item, [delegate() viewForFetchedAvatar]);
161 EXPECT_TRUE( 161 EXPECT_TRUE(
162 ImagesEqual([CredentialItemView defaultAvatar], [item avatarView].image)); 162 ImagesEqual([CredentialItemView defaultAvatar], [item avatarView].image));
163 163
164 [item updateAvatar:nil]; 164 [item updateAvatar:nil];
165 EXPECT_FALSE([item avatarView].image); 165 EXPECT_FALSE([item avatarView].image);
166 } 166 }
167 167
168 TEST_F(CredentialItemViewTest, CredentialWithNameAndAvatar) { 168 TEST_F(CredentialItemViewTest, CredentialWithNameAndAvatar) {
169 autofill::PasswordForm form(CredentialWithNameAndAvatar()); 169 autofill::PasswordForm form(CredentialWithNameAndAvatar());
170 CredentialItemView* item = view(form); 170 CredentialItemView* item = view(form);
171 171
172 EXPECT_NSEQ(base::SysUTF16ToNSString(form.display_name), 172 EXPECT_NSEQ(base::SysUTF16ToNSString(form.display_name),
173 [item upperLabel].stringValue); 173 [item upperLabel].stringValue);
174 EXPECT_NSEQ(base::SysUTF16ToNSString(form.username_value), 174 EXPECT_NSEQ(base::SysUTF16ToNSString(form.username_value),
175 [item lowerLabel].stringValue); 175 [item lowerLabel].stringValue);
176 EXPECT_TRUE([delegate() didFetchAvatar]); 176 EXPECT_TRUE([delegate() didFetchAvatar]);
177 EXPECT_EQ(form.avatar_url, [delegate() fetchedAvatarURL]); 177 EXPECT_EQ(form.icon_url, [delegate() fetchedAvatarURL]);
178 EXPECT_EQ(item, [delegate() viewForFetchedAvatar]); 178 EXPECT_EQ(item, [delegate() viewForFetchedAvatar]);
179 EXPECT_TRUE( 179 EXPECT_TRUE(
180 ImagesEqual([CredentialItemView defaultAvatar], [item avatarView].image)); 180 ImagesEqual([CredentialItemView defaultAvatar], [item avatarView].image));
181 181
182 [item updateAvatar:nil]; 182 [item updateAvatar:nil];
183 EXPECT_FALSE([item avatarView].image); 183 EXPECT_FALSE([item avatarView].image);
184 } 184 }
185 185
186 } // namespace 186 } // namespace
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698