components/password_manager/core/browser/login_database_unittest.cc - Issue 1220713005: Rename avatar_url to icon_url in PasswordForm.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/login_database_unittest.cc

Issue 1220713005: Rename avatar_url to icon_url in PasswordForm. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@rename2

Patch Set: Rebased. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/login_database.cc ('k') | components/password_manager/core/browser/password_manager_test_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/login_database_unittest.cc

diff --git a/components/password_manager/core/browser/login_database_unittest.cc b/components/password_manager/core/browser/login_database_unittest.cc

index 9e323ce8bf8c487c20bbc04ce22ff4216b22f0c5..512b8fd5837e803aa228ec060b70b5d5bce69302 100644

--- a/components/password_manager/core/browser/login_database_unittest.cc

+++ b/components/password_manager/core/browser/login_database_unittest.cc

@@ -59,7 +59,7 @@ void GenerateExamplePasswordForm(PasswordForm* form) {

form->form_data.name = ASCIIToUTF16("form_name");

form->date_synced = base::Time::Now();

form->display_name = ASCIIToUTF16("Mr. Smith");

- form->avatar_url = GURL("https://accounts.google.com/Avatar");

+ form->icon_url = GURL("https://accounts.google.com/Icon");

form->federation_url = GURL("https://accounts.google.com/federation");

form->skip_zero_click = true;

}

@@ -609,7 +609,7 @@ static bool AddTimestampedLogin(LoginDatabase* db,

form.submit_element = ASCIIToUTF16("signIn");

form.signon_realm = url;

form.display_name = ASCIIToUTF16(unique_string);

- form.avatar_url = GURL("https://accounts.google.com/Avatar");

+ form.icon_url = GURL("https://accounts.google.com/Icon");

form.federation_url = GURL("https://accounts.google.com/federation");

form.skip_zero_click = true;

@@ -733,7 +733,7 @@ TEST_F(LoginDatabaseTest, BlacklistedLogins) {

form.scheme = PasswordForm::SCHEME_HTML;

form.date_synced = base::Time::Now();

form.display_name = ASCIIToUTF16("Mr. Smith");

- form.avatar_url = GURL("https://accounts.google.com/Avatar");

+ form.icon_url = GURL("https://accounts.google.com/Icon");

form.federation_url = GURL("https://accounts.google.com/federation");

form.skip_zero_click = true;

EXPECT_EQ(AddChangeForForm(form), db().AddLogin(form));

@@ -957,7 +957,7 @@ TEST_F(LoginDatabaseTest, UpdateLogin) {

form.scheme = PasswordForm::SCHEME_BASIC;

form.type = PasswordForm::TYPE_GENERATED;

form.display_name = ASCIIToUTF16("Mr. Smith");

- form.avatar_url = GURL("https://accounts.google.com/Avatar");

+ form.icon_url = GURL("https://accounts.google.com/Icon");

form.federation_url = GURL("https://accounts.google.com/federation");

form.skip_zero_click = true;

EXPECT_EQ(UpdateChangeForForm(form), db().UpdateLogin(form));