Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(954)

Unified Diff: components/autofill/core/common/password_form.h

Issue 1220713005: Rename avatar_url to icon_url in PasswordForm. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@rename2
Patch Set: Rebased. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/common/password_form.h
diff --git a/components/autofill/core/common/password_form.h b/components/autofill/core/common/password_form.h
index 88a7840fd84cfe3dd91376e2ea96956689be044e..67da0ec36246b97efbd3b0ebedbb1cf8757c41ae 100644
--- a/components/autofill/core/common/password_form.h
+++ b/components/autofill/core/common/password_form.h
@@ -246,11 +246,13 @@ struct PasswordForm {
// User friendly name to show in the UI.
base::string16 display_name;
- // The URL of the user's avatar to display in the UI. Note that the
- // corresponding property in the Credential Manager is called icon URL.
- // TODO(msramek): Rename |avatar_url| to |icon_url| to match the naming
- // in Credential Manager.
- GURL avatar_url;
+ // The URL of this credential's icon, such as the user's avatar, to display
+ // in the UI.
+ // TODO(msramek): This field was previously named |avatar_url|. It is still
+ // named this way in the password store backends (e.g. the avatar_url column
+ // in the SQL DB of LoginDatabase) and for the purposes of syncing
+ // (i.e in PasswordSpecificsData). Rename these occurrences.
+ GURL icon_url;
// The URL of identity provider used for federated login.
GURL federation_url;

Powered by Google App Engine
This is Rietveld 408576698