Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/password_manager/core/common/credential_manager_types_unittest.cc

Issue 1220713005: Rename avatar_url to icon_url in PasswordForm. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@rename2
Patch Set: Rebased. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/password_manager/core/common/credential_manager_types.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/core/common/credential_manager_types_unittest.cc
diff --git a/components/password_manager/core/common/credential_manager_types_unittest.cc b/components/password_manager/core/common/credential_manager_types_unittest.cc
index cdbe48f6bd4705fd145cf2d6a77422b0321b3a46..ff2e39c1c6190e24e064e4b935649f32f4f8b99a 100644
--- a/components/password_manager/core/common/credential_manager_types_unittest.cc
+++ b/components/password_manager/core/common/credential_manager_types_unittest.cc
@@ -47,7 +47,7 @@ TEST_F(CredentialManagerTypesTest, CreatePasswordFormFederation) {
form = CreatePasswordFormFromCredentialInfo(info, origin_);
ASSERT_NE(nullptr, form.get());
- EXPECT_EQ(info.icon, form->avatar_url);
+ EXPECT_EQ(info.icon, form->icon_url);
EXPECT_EQ(info.name, form->display_name);
EXPECT_EQ(origin_, form->origin);
EXPECT_EQ(autofill::PasswordForm::SCHEME_HTML, form->scheme);
@@ -72,7 +72,7 @@ TEST_F(CredentialManagerTypesTest, CreatePasswordFormLocal) {
form = CreatePasswordFormFromCredentialInfo(info, origin_);
ASSERT_NE(nullptr, form.get());
- EXPECT_EQ(info.icon, form->avatar_url);
+ EXPECT_EQ(info.icon, form->icon_url);
EXPECT_EQ(info.name, form->display_name);
EXPECT_EQ(origin_, form->origin);
EXPECT_EQ(autofill::PasswordForm::SCHEME_HTML, form->scheme);
« no previous file with comments | « components/password_manager/core/common/credential_manager_types.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698