Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Side by Side Diff: chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc

Issue 1220713005: Rename avatar_url to icon_url in PasswordForm. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@rename2
Patch Set: Rebased. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <algorithm> 5 #include <algorithm>
6 #include <map> 6 #include <map>
7 #include <set> 7 #include <set>
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 151 matching lines...) Expand 10 before | Expand all | Expand 10 after
162 old_form_google_.signon_realm = "Google"; 162 old_form_google_.signon_realm = "Google";
163 old_form_google_.date_created = base::Time::Now(); 163 old_form_google_.date_created = base::Time::Now();
164 164
165 form_google_ = old_form_google_; 165 form_google_ = old_form_google_;
166 form_google_.times_used = 3; 166 form_google_.times_used = 3;
167 form_google_.type = PasswordForm::TYPE_GENERATED; 167 form_google_.type = PasswordForm::TYPE_GENERATED;
168 form_google_.form_data.name = UTF8ToUTF16("form_name"); 168 form_google_.form_data.name = UTF8ToUTF16("form_name");
169 form_google_.date_synced = base::Time::Now(); 169 form_google_.date_synced = base::Time::Now();
170 form_google_.date_created = old_form_google_.date_created; 170 form_google_.date_created = old_form_google_.date_created;
171 form_google_.display_name = UTF8ToUTF16("Joe Schmoe"); 171 form_google_.display_name = UTF8ToUTF16("Joe Schmoe");
172 form_google_.avatar_url = GURL("http://www.google.com/avatar"); 172 form_google_.icon_url = GURL("http://www.google.com/icon");
173 form_google_.federation_url = GURL("http://www.google.com/federation_url"); 173 form_google_.federation_url = GURL("http://www.google.com/federation_url");
174 form_google_.skip_zero_click = true; 174 form_google_.skip_zero_click = true;
175 form_google_.generation_upload_status = PasswordForm::NEGATIVE_SIGNAL_SENT; 175 form_google_.generation_upload_status = PasswordForm::NEGATIVE_SIGNAL_SENT;
176 176
177 form_isc_.origin = GURL("http://www.isc.org/"); 177 form_isc_.origin = GURL("http://www.isc.org/");
178 form_isc_.action = GURL("http://www.isc.org/auth"); 178 form_isc_.action = GURL("http://www.isc.org/auth");
179 form_isc_.username_element = UTF8ToUTF16("id"); 179 form_isc_.username_element = UTF8ToUTF16("id");
180 form_isc_.username_value = UTF8ToUTF16("janedoe"); 180 form_isc_.username_value = UTF8ToUTF16("janedoe");
181 form_isc_.password_element = UTF8ToUTF16("passwd"); 181 form_isc_.password_element = UTF8ToUTF16("passwd");
182 form_isc_.password_value = UTF8ToUTF16("ihazabukkit"); 182 form_isc_.password_value = UTF8ToUTF16("ihazabukkit");
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
218 EXPECT_EQ(expected.preferred, actual.preferred); 218 EXPECT_EQ(expected.preferred, actual.preferred);
219 if (check_date_created) { 219 if (check_date_created) {
220 EXPECT_EQ(expected.date_created, actual.date_created); 220 EXPECT_EQ(expected.date_created, actual.date_created);
221 } 221 }
222 EXPECT_EQ(expected.blacklisted_by_user, actual.blacklisted_by_user); 222 EXPECT_EQ(expected.blacklisted_by_user, actual.blacklisted_by_user);
223 EXPECT_EQ(expected.type, actual.type); 223 EXPECT_EQ(expected.type, actual.type);
224 EXPECT_EQ(expected.times_used, actual.times_used); 224 EXPECT_EQ(expected.times_used, actual.times_used);
225 EXPECT_EQ(expected.scheme, actual.scheme); 225 EXPECT_EQ(expected.scheme, actual.scheme);
226 EXPECT_EQ(expected.date_synced, actual.date_synced); 226 EXPECT_EQ(expected.date_synced, actual.date_synced);
227 EXPECT_EQ(expected.display_name, actual.display_name); 227 EXPECT_EQ(expected.display_name, actual.display_name);
228 EXPECT_EQ(expected.avatar_url, actual.avatar_url); 228 EXPECT_EQ(expected.icon_url, actual.icon_url);
229 EXPECT_EQ(expected.federation_url, actual.federation_url); 229 EXPECT_EQ(expected.federation_url, actual.federation_url);
230 EXPECT_EQ(expected.skip_zero_click, actual.skip_zero_click); 230 EXPECT_EQ(expected.skip_zero_click, actual.skip_zero_click);
231 EXPECT_EQ(expected.generation_upload_status, actual.generation_upload_status); 231 EXPECT_EQ(expected.generation_upload_status, actual.generation_upload_status);
232 } 232 }
233 233
234 // static 234 // static
235 void NativeBackendKWalletTestBase::CheckPasswordChanges( 235 void NativeBackendKWalletTestBase::CheckPasswordChanges(
236 const PasswordStoreChangeList& expected, 236 const PasswordStoreChangeList& expected,
237 const PasswordStoreChangeList& actual) { 237 const PasswordStoreChangeList& actual) {
238 ASSERT_EQ(expected.size(), actual.size()); 238 ASSERT_EQ(expected.size(), actual.size());
(...skipping 738 matching lines...) Expand 10 before | Expand all | Expand 10 after
977 return; 977 return;
978 pickle->WriteInt(form.type); 978 pickle->WriteInt(form.type);
979 pickle->WriteInt(form.times_used); 979 pickle->WriteInt(form.times_used);
980 autofill::SerializeFormData(form.form_data, pickle); 980 autofill::SerializeFormData(form.form_data, pickle);
981 if (effective_version < 3) 981 if (effective_version < 3)
982 return; 982 return;
983 pickle->WriteInt64(form.date_synced.ToInternalValue()); 983 pickle->WriteInt64(form.date_synced.ToInternalValue());
984 if (effective_version < 4) 984 if (effective_version < 4)
985 return; 985 return;
986 pickle->WriteString16(form.display_name); 986 pickle->WriteString16(form.display_name);
987 pickle->WriteString(form.avatar_url.spec()); 987 pickle->WriteString(form.icon_url.spec());
988 pickle->WriteString(form.federation_url.spec()); 988 pickle->WriteString(form.federation_url.spec());
989 pickle->WriteBool(form.skip_zero_click); 989 pickle->WriteBool(form.skip_zero_click);
990 if (effective_version < 7) 990 if (effective_version < 7)
991 return; 991 return;
992 pickle->WriteInt(form.generation_upload_status); 992 pickle->WriteInt(form.generation_upload_status);
993 } 993 }
994 994
995 void NativeBackendKWalletPickleTest::CreateVersion0Pickle( 995 void NativeBackendKWalletPickleTest::CreateVersion0Pickle(
996 bool size_32, 996 bool size_32,
997 const PasswordForm& form, 997 const PasswordForm& form,
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
1059 if (form_list.size() > 0) 1059 if (form_list.size() > 0)
1060 CheckPasswordForm(form, *form_list[0], true); 1060 CheckPasswordForm(form, *form_list[0], true);
1061 } 1061 }
1062 1062
1063 void NativeBackendKWalletPickleTest::CheckVersion3Pickle() { 1063 void NativeBackendKWalletPickleTest::CheckVersion3Pickle() {
1064 base::Pickle pickle; 1064 base::Pickle pickle;
1065 PasswordForm default_values; 1065 PasswordForm default_values;
1066 PasswordForm form = form_google_; 1066 PasswordForm form = form_google_;
1067 // Remove the fields which were not present in version #3. 1067 // Remove the fields which were not present in version #3.
1068 form.display_name = default_values.display_name; 1068 form.display_name = default_values.display_name;
1069 form.avatar_url = default_values.avatar_url; 1069 form.icon_url = default_values.icon_url;
1070 form.federation_url = default_values.federation_url; 1070 form.federation_url = default_values.federation_url;
1071 form.skip_zero_click = default_values.skip_zero_click; 1071 form.skip_zero_click = default_values.skip_zero_click;
1072 form.generation_upload_status = default_values.generation_upload_status; 1072 form.generation_upload_status = default_values.generation_upload_status;
1073 CreateVersion1PlusPickle(form, &pickle, 3, 3); 1073 CreateVersion1PlusPickle(form, &pickle, 3, 3);
1074 1074
1075 ScopedVector<PasswordForm> form_list = 1075 ScopedVector<PasswordForm> form_list =
1076 NativeBackendKWalletStub::DeserializeValue(form.signon_realm, pickle); 1076 NativeBackendKWalletStub::DeserializeValue(form.signon_realm, pickle);
1077 1077
1078 EXPECT_EQ(1u, form_list.size()); 1078 EXPECT_EQ(1u, form_list.size());
1079 if (form_list.size() > 0) 1079 if (form_list.size() > 0)
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
1184 } 1184 }
1185 1185
1186 TEST_F(NativeBackendKWalletPickleTest, CheckVersion5Pickle) { 1186 TEST_F(NativeBackendKWalletPickleTest, CheckVersion5Pickle) {
1187 CheckVersion5Pickle(); 1187 CheckVersion5Pickle();
1188 } 1188 }
1189 1189
1190 TEST_F(NativeBackendKWalletPickleTest, CheckVersion6Pickle) { 1190 TEST_F(NativeBackendKWalletPickleTest, CheckVersion6Pickle) {
1191 CheckVersion6Pickle(false); 1191 CheckVersion6Pickle(false);
1192 CheckVersion6Pickle(true); 1192 CheckVersion6Pickle(true);
1193 } 1193 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698