Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1326)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1109863004: Use GLSLCaps for creating processor keys and GLSL-specific programs (Closed)

Created:
5 years, 8 months ago by jvanverth1
Modified:
5 years, 7 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Use GLSLCaps for creating processor keys and GLSL-specific programs Effectively all this does is future-proof any GLSL-specific code, as GLSLCaps is just a typedef of GLCaps. BUG=skia: Committed: https://skia.googlesource.com/skia/+/cfc18867d982119d9dc2888bf09f1093012daadd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1798 lines, -1778 lines) Patch
M gm/dcshader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M include/effects/SkTableColorFilter.h View 1 chunk +6 lines, -0 lines 0 comments Download
M include/gpu/GrFragmentProcessor.h View 2 chunks +2 lines, -1 line 0 comments Download
M include/gpu/GrXferProcessor.h View 3 chunks +3 lines, -2 lines 0 comments Download
M include/gpu/effects/GrConstColorProcessor.h View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkArithmeticMode_gpu.h View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkArithmeticMode_gpu.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M src/effects/SkColorCubeFilter.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M src/effects/SkColorFilters.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkColorMatrixFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M src/effects/SkLumaColorFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkMagnifierImageFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M src/effects/SkPerlinNoiseShader.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/effects/SkTableColorFilter.cpp View 4 chunks +9 lines, -3 lines 0 comments Download
M src/effects/gradients/SkLinearGradient.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/gradients/SkRadialGradient.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/gradients/SkSweepGradient.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient_gpu.cpp View 20 chunks +20 lines, -20 lines 0 comments Download
M src/effects/gradients/SkTwoPointRadialGradient.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrDefaultGeoProcFactory.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 6 chunks +9 lines, -9 lines 0 comments Download
M src/gpu/GrPathProcessor.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrPathProcessor.cpp View 1 chunk +75 lines, -75 lines 0 comments Download
M src/gpu/GrPrimitiveProcessor.h View 3 chunks +3 lines, -2 lines 0 comments Download
M src/gpu/GrProgramDesc.h View 1 chunk +15 lines, -15 lines 0 comments Download
M src/gpu/GrXferProcessor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrBezierEffect.h View 3 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.cpp View 9 chunks +12 lines, -12 lines 0 comments Download
M src/gpu/effects/GrBicubicEffect.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrBicubicEffect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrBitmapTextGeoProc.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrBitmapTextGeoProc.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrConstColorProcessor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrConvexPolyEffect.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrConvexPolyEffect.cpp View 6 chunks +7 lines, -7 lines 0 comments Download
M src/gpu/effects/GrConvolutionEffect.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrConvolutionEffect.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrCoverageSetOpXP.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrCustomXfermode.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/effects/GrCustomXfermodePriv.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 8 chunks +12 lines, -12 lines 0 comments Download
M src/gpu/effects/GrDisableColorXP.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldGeoProc.h View 3 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldGeoProc.cpp View 6 chunks +9 lines, -9 lines 0 comments Download
M src/gpu/effects/GrDitherEffect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrMatrixConvolutionEffect.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrMatrixConvolutionEffect.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrOvalEffect.cpp View 8 chunks +8 lines, -8 lines 0 comments Download
M src/gpu/effects/GrPorterDuffXferProcessor.cpp View 1 chunk +709 lines, -709 lines 0 comments Download
M src/gpu/effects/GrRRectEffect.cpp View 8 chunks +8 lines, -8 lines 0 comments Download
M src/gpu/effects/GrSimpleTextureEffect.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrSimpleTextureEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrTextureDomain.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrTextureDomain.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrYUVtoRGBEffect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLCaps.h View 1 chunk +400 lines, -398 lines 0 comments Download
M src/gpu/gl/GrGLPathProcessor.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLPathProcessor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLProcessor.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLProgramDesc.cpp View 3 chunks +3 lines, -0 lines 0 comments Download
M tests/GLProgramsTest.cpp View 1 chunk +369 lines, -369 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jvanverth1
As this just aliases GrGLSLCaps to be GrGLCaps, I'm not sure how useful it is. ...
5 years, 8 months ago (2015-04-27 19:04:32 UTC) #2
bsalomon
lgtm
5 years, 7 months ago (2015-04-28 15:35:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109863004/1
5 years, 7 months ago (2015-04-28 15:37:51 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 15:48:24 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/cfc18867d982119d9dc2888bf09f1093012daadd

Powered by Google App Engine
This is Rietveld 408576698