Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 100543005: Update all users of base::Version to explicitly specify the namespace, and clean up the header. (Closed)

Created:
7 years ago by Avi (use Gerrit)
Modified:
7 years ago
Reviewers:
brettw
CC:
chromium-reviews, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, darin-cc_chromium.org, nkostylev+watch_chromium.org, robertshield, Ilya Sherman, amit, jam, piman+watch_chromium.org, asvitkine+watch_chromium.org, feature-media-reviews_chromium.org, rginda+watch_chromium.org, joi+watch-content_chromium.org, stuartmorgan+watch_chromium.org, oshima+watch_chromium.org, grt+watch_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, jar (doing other things)
Visibility:
Public.

Description

Update all users of base::Version to explicitly specify the namespace, and clean up the header. BUG=none TEST=no change TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242414

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : fix #

Patch Set 4 : fix #

Patch Set 5 : someday it will work #

Unified diffs Side-by-side diffs Delta from patch set Stats (+426 lines, -424 lines) Patch
M base/version.h View 1 chunk +0 lines, -4 lines 0 comments Download
M base/version_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/app/chrome_breakpad_client.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/client_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_browser_main_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/external_cache.cc View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/component_updater/component_updater_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/component_updater_service.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/component_updater/crx_update_item.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/component_updater/pepper_flash_component_installer.cc View 13 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/component_updater/pnacl/pnacl_component_installer.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/component_updater/recovery_component_installer.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/component_updater/swiftshader_component_installer.cc View 8 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/component_updater/test/component_installers_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/test/component_updater_service_unittest.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/test/component_updater_service_unittest.cc View 13 chunks +27 lines, -16 lines 0 comments Download
M chrome/browser/component_updater/test/test_installer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/test/test_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/update_response.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/enumerate_modules_model_win.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/runtime/runtime_api.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/extensions/crx_installer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/crx_installer.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 2 3 15 chunks +20 lines, -20 lines 0 comments Download
M chrome/browser/extensions/extension_sync_data.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_sync_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_sync_data_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/external_policy_loader_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/external_provider_impl.cc View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/external_registry_loader_win.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/updater/extension_downloader.cc View 7 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/extensions/updater/extension_downloader_delegate.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/updater/extension_updater_unittest.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/user_script_master.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/webstore_installer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/webstore_installer.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/first_run/upgrade_util_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/hang_monitor/hung_plugin_action.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/crl_set_fetcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/plugins/plugin_finder.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugins/plugin_installer.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/plugins/plugin_metadata.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/plugins/plugin_metadata.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/plugins/plugin_metadata_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/prefs/session_startup_pref.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/chrome_version_service.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/pdf/pdf_unsupported_feature.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/startup/default_browser_prompt.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/help/version_updater_win.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/upgrade_detector_impl.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/chrome_paths.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/manifest_handlers/minimum_chrome_version_checker.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/update_manifest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/service_process_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/service_process_util_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/setup/install.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/setup/install.cc View 1 2 3 4 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/installer/setup/install_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/setup/install_worker.cc View 1 2 3 4 18 chunks +22 lines, -22 lines 0 comments Download
M chrome/installer/setup/install_worker_unittest.cc View 1 2 3 4 8 chunks +10 lines, -10 lines 0 comments Download
M chrome/installer/setup/setup_main.cc View 1 2 3 4 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/installer/setup/setup_util.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/setup/setup_util.cc View 1 2 3 4 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/installer/setup/setup_util_unittest.cc View 1 2 3 4 5 chunks +9 lines, -9 lines 0 comments Download
M chrome/installer/setup/uninstall.cc View 1 3 chunks +7 lines, -6 lines 0 comments Download
M chrome/installer/test/alternate_version_generator.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/installer/util/browser_distribution.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/browser_distribution.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/fake_installation_state.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/installer/util/fake_product_state.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/google_chrome_distribution.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/google_chrome_distribution.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/google_chrome_distribution_dummy.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/google_update_settings.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/google_update_settings.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/installer/util/google_update_settings_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/install_util.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/installer/util/installation_state.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/installer/util/installation_state.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/installer/util/installation_validator.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/util/installation_validator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/installer_state.cc View 1 2 3 4 9 chunks +15 lines, -15 lines 0 comments Download
M chrome/installer/util/installer_state_unittest.cc View 1 2 3 4 15 chunks +35 lines, -33 lines 0 comments Download
M chrome/installer/util/product_state_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/util/product_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/media/chrome_key_systems.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/gpu/gpu_feature_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/mini_installer_test/installer_test_util.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/dll_redirector.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome_frame/test/dll_redirector_loading_test.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M chrome_frame/test/dll_redirector_test.cc View 12 chunks +21 lines, -21 lines 0 comments Download
M chrome_frame/test/test_with_web_server.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M components/variations/processed_study.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/variations/variations_seed_processor_unittest.cc View 3 chunks +8 lines, -12 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl_private.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/plugin_data_remover_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/npapi/webplugin_delegate_impl_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/webplugininfo_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/webplugininfo.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/npapi/webplugin_delegate_proxy.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/pending_extension_info.h View 3 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/pending_extension_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/pending_extension_manager.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M extensions/common/extension.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/manifest_handlers/shared_module_info.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M gpu/config/gpu_info.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/config/gpu_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/config/gpu_info_collector_win.cc View 1 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
Avi (use Gerrit)
7 years ago (2013-12-20 23:00:48 UTC) #1
brettw
lgtm
7 years ago (2013-12-20 23:13:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/100543005/60001
7 years ago (2013-12-20 23:45:58 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=239372
7 years ago (2013-12-21 00:32:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/100543005/320001
7 years ago (2013-12-21 00:46:47 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=239415
7 years ago (2013-12-21 01:44:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/100543005/320001
7 years ago (2013-12-21 03:21:54 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) app_list_unittests, ash_unittests, aura_unittests, base_unittests, base_unittests_swarm, browser_tests, ...
7 years ago (2013-12-21 06:47:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/100543005/320001
7 years ago (2013-12-21 08:33:04 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_x64_rel for step(s) base_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_rel&number=63947
7 years ago (2013-12-21 11:03:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/100543005/320001
7 years ago (2013-12-21 16:57:17 UTC) #11
commit-bot: I haz the power
Retried try job too often on win_x64_rel for step(s) base_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_rel&number=63953
7 years ago (2013-12-21 19:41:47 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/100543005/320001
7 years ago (2013-12-21 19:58:05 UTC) #13
commit-bot: I haz the power
Retried try job too often on win_x64_rel for step(s) base_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_rel&number=63964
7 years ago (2013-12-21 22:45:02 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/100543005/320001
7 years ago (2013-12-23 17:14:17 UTC) #15
commit-bot: I haz the power
Retried try job too often on win for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=136856
7 years ago (2013-12-23 19:32:14 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/100543005/990001
7 years ago (2013-12-23 19:46:50 UTC) #17
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=239817
7 years ago (2013-12-23 20:31:38 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/100543005/1090002
7 years ago (2013-12-23 20:59:17 UTC) #19
commit-bot: I haz the power
7 years ago (2013-12-23 23:37:06 UTC) #20
Message was sent while issue was closed. 
Change committed as 242414

Powered by Google App Engine
This is Rietveld 408576698