Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: chrome/app/chrome_breakpad_client.cc

Issue 100543005: Update all users of base::Version to explicitly specify the namespace, and clean up the header. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: someday it will work Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/version_unittest.cc ('k') | chrome/app/client_util.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/app/chrome_breakpad_client.h" 5 #include "chrome/app/chrome_breakpad_client.h"
6 6
7 #include "base/atomicops.h" 7 #include "base/atomicops.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/environment.h" 9 #include "base/environment.h"
10 #include "base/files/file_path.h" 10 #include "base/files/file_path.h"
(...skipping 159 matching lines...) Expand 10 before | Expand all | Expand 10 after
170 scoped_ptr<base::Environment> env(base::Environment::Create()); 170 scoped_ptr<base::Environment> env(base::Environment::Create());
171 if (!env->HasVar(env_vars::kRestartInfo)) 171 if (!env->HasVar(env_vars::kRestartInfo))
172 return false; 172 return false;
173 173
174 env->SetVar(env_vars::kShowRestart, "1"); 174 env->SetVar(env_vars::kShowRestart, "1");
175 return true; 175 return true;
176 } 176 }
177 177
178 bool ChromeBreakpadClient::GetDeferredUploadsSupported( 178 bool ChromeBreakpadClient::GetDeferredUploadsSupported(
179 bool is_per_user_install) { 179 bool is_per_user_install) {
180 Version update_version = GoogleUpdateSettings::GetGoogleUpdateVersion( 180 base::Version update_version = GoogleUpdateSettings::GetGoogleUpdateVersion(
181 !is_per_user_install); 181 !is_per_user_install);
182 if (!update_version.IsValid() || 182 if (!update_version.IsValid() ||
183 update_version.IsOlderThan(std::string(kMinUpdateVersion))) 183 update_version.IsOlderThan(std::string(kMinUpdateVersion)))
184 return false; 184 return false;
185 185
186 return true; 186 return true;
187 } 187 }
188 188
189 bool ChromeBreakpadClient::GetIsPerUserInstall(const base::FilePath& exe_path) { 189 bool ChromeBreakpadClient::GetIsPerUserInstall(const base::FilePath& exe_path) {
190 return InstallUtil::IsPerUserInstall(exe_path.value().c_str()); 190 return InstallUtil::IsPerUserInstall(exe_path.value().c_str());
(...skipping 186 matching lines...) Expand 10 before | Expand all | Expand 10 after
377 bool ChromeBreakpadClient::EnableBreakpadForProcess( 377 bool ChromeBreakpadClient::EnableBreakpadForProcess(
378 const std::string& process_type) { 378 const std::string& process_type) {
379 return process_type == switches::kRendererProcess || 379 return process_type == switches::kRendererProcess ||
380 process_type == switches::kPluginProcess || 380 process_type == switches::kPluginProcess ||
381 process_type == switches::kPpapiPluginProcess || 381 process_type == switches::kPpapiPluginProcess ||
382 process_type == switches::kZygoteProcess || 382 process_type == switches::kZygoteProcess ||
383 process_type == switches::kGpuProcess; 383 process_type == switches::kGpuProcess;
384 } 384 }
385 385
386 } // namespace chrome 386 } // namespace chrome
OLDNEW
« no previous file with comments | « base/version_unittest.cc ('k') | chrome/app/client_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698