chrome/installer/setup/install_unittest.cc - Issue 100543005: Update all users of base::Version to explicitly specify the namespace, and clean up the header.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/setup/install_unittest.cc

Issue 100543005: Update all users of base::Version to explicitly specify the namespace, and clean up the header. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: someday it will work Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/installer/setup/install_unittest.cc

diff --git a/chrome/installer/setup/install_unittest.cc b/chrome/installer/setup/install_unittest.cc

index 99337d01644131d114d6d0a50fbecdf17ea6b878..5164ee3ff2950e85b0518d75bcd92596ac6acea3 100644

--- a/chrome/installer/setup/install_unittest.cc

+++ b/chrome/installer/setup/install_unittest.cc

@@ -38,7 +38,7 @@ class CreateVisualElementsManifestTest : public testing::Test {

// Create a temp directory for testing.

ASSERT_TRUE(test_dir_.CreateUniqueTempDir());

- version_ = Version("0.0.0.0");

+ version_ = base::Version("0.0.0.0");

version_dir_ = test_dir_.path().AppendASCII(version_.GetString());

ASSERT_TRUE(base::CreateDirectory(version_dir_));

@@ -56,7 +56,7 @@ class CreateVisualElementsManifestTest : public testing::Test {

base::ScopedTempDir test_dir_;

// A dummy version number used to create the version directory.

- Version version_;

+ base::Version version_;

// The path to |test_dir_|\|version_|.

base::FilePath version_dir_;

« no previous file with comments | « chrome/installer/setup/install.cc ('k') | chrome/installer/setup/install_worker.cc » ('j') | no next file with comments »