Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Unified Diff: components/variations/variations_seed_processor_unittest.cc

Issue 100543005: Update all users of base::Version to explicitly specify the namespace, and clean up the header. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: someday it will work Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/variations/processed_study.cc ('k') | content/browser/gpu/gpu_data_manager_impl_private.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/variations/variations_seed_processor_unittest.cc
diff --git a/components/variations/variations_seed_processor_unittest.cc b/components/variations/variations_seed_processor_unittest.cc
index cbf0864cdd2bbf6931d2a19f8a5c67b444db0078..e03fcd989a7d2915df0012d35a87476b70057989 100644
--- a/components/variations/variations_seed_processor_unittest.cc
+++ b/components/variations/variations_seed_processor_unittest.cc
@@ -399,9 +399,8 @@ TEST_F(VariationsSeedProcessorTest, CheckStudyVersion) {
for (size_t i = 0; i < ARRAYSIZE_UNSAFE(min_test_cases); ++i) {
filter.set_min_version(min_test_cases[i].min_version);
- const bool result =
- seed_processor.CheckStudyVersion(filter,
- Version(min_test_cases[i].version));
+ const bool result = seed_processor.CheckStudyVersion(
+ filter, base::Version(min_test_cases[i].version));
EXPECT_EQ(min_test_cases[i].expected_result, result) <<
"Min. version case " << i << " failed!";
}
@@ -409,9 +408,8 @@ TEST_F(VariationsSeedProcessorTest, CheckStudyVersion) {
for (size_t i = 0; i < ARRAYSIZE_UNSAFE(max_test_cases); ++i) {
filter.set_max_version(max_test_cases[i].max_version);
- const bool result =
- seed_processor.CheckStudyVersion(filter,
- Version(max_test_cases[i].version));
+ const bool result = seed_processor.CheckStudyVersion(
+ filter, base::Version(max_test_cases[i].version));
EXPECT_EQ(max_test_cases[i].expected_result, result) <<
"Max version case " << i << " failed!";
}
@@ -423,16 +421,14 @@ TEST_F(VariationsSeedProcessorTest, CheckStudyVersion) {
filter.set_max_version(max_test_cases[j].max_version);
if (!min_test_cases[i].expected_result) {
- const bool result =
- seed_processor.CheckStudyVersion(
- filter, Version(min_test_cases[i].version));
+ const bool result = seed_processor.CheckStudyVersion(
+ filter, base::Version(min_test_cases[i].version));
EXPECT_FALSE(result) << "Case " << i << "," << j << " failed!";
}
if (!max_test_cases[j].expected_result) {
- const bool result =
- seed_processor.CheckStudyVersion(
- filter, Version(max_test_cases[j].version));
+ const bool result = seed_processor.CheckStudyVersion(
+ filter, base::Version(max_test_cases[j].version));
EXPECT_FALSE(result) << "Case " << i << "," << j << " failed!";
}
}
« no previous file with comments | « components/variations/processed_study.cc ('k') | content/browser/gpu/gpu_data_manager_impl_private.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698