Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Unified Diff: chrome/browser/extensions/crx_installer.h

Issue 100543005: Update all users of base::Version to explicitly specify the namespace, and clean up the header. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: someday it will work Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/api/runtime/runtime_api.cc ('k') | chrome/browser/extensions/crx_installer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/crx_installer.h
diff --git a/chrome/browser/extensions/crx_installer.h b/chrome/browser/extensions/crx_installer.h
index 7facb81659e1ed0bd12037a9e4361866aaca0510..87f650bb8744fea7506c78bc5728d55cc6ff2f6e 100644
--- a/chrome/browser/extensions/crx_installer.h
+++ b/chrome/browser/extensions/crx_installer.h
@@ -125,8 +125,8 @@ class CrxInstaller
const std::string& expected_id() const { return expected_id_; }
void set_expected_id(const std::string& val) { expected_id_ = val; }
- void set_expected_version(const Version& val) {
- expected_version_.reset(new Version(val));
+ void set_expected_version(const base::Version& val) {
+ expected_version_.reset(new base::Version(val));
expected_version_strict_checking_ = true;
}
@@ -297,7 +297,7 @@ class CrxInstaller
// installing. Important for external sources, where claiming the wrong
// version could cause unnecessary unpacking of an extension at every
// restart.
- scoped_ptr<Version> expected_version_;
+ scoped_ptr<base::Version> expected_version_;
// If true, the actual version should be same with the |expected_version_|,
// Otherwise the actual version should be equal to or newer than
« no previous file with comments | « chrome/browser/extensions/api/runtime/runtime_api.cc ('k') | chrome/browser/extensions/crx_installer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698