Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: chrome/app/client_util.cc

Issue 100543005: Update all users of base::Version to explicitly specify the namespace, and clean up the header. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: someday it will work Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/chrome_breakpad_client.cc ('k') | chrome/browser/chrome_browser_main_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/client_util.cc
diff --git a/chrome/app/client_util.cc b/chrome/app/client_util.cc
index 3d5ba1b56c869c1daf65cede80f67a982f1b7d60..ac8734e54649996304c0574bc11cbfa501c7c2fc 100644
--- a/chrome/app/client_util.cc
+++ b/chrome/app/client_util.cc
@@ -202,7 +202,7 @@ base::string16 GetCurrentModuleVersion() {
FileVersionInfo::CreateFileVersionInfoForCurrentModule());
if (file_version_info.get()) {
base::string16 version_string(file_version_info->file_version());
- if (Version(WideToASCII(version_string)).IsValid())
+ if (base::Version(WideToASCII(version_string)).IsValid())
return version_string;
}
return base::string16();
@@ -238,7 +238,7 @@ HMODULE MainDllLoader::Load(base::string16* out_version,
// This is used to support Chrome Frame, see http://crbug.com/88589.
version_string = cmd_line.GetSwitchValueNative(switches::kChromeVersion);
- if (!Version(WideToASCII(version_string)).IsValid()) {
+ if (!base::Version(WideToASCII(version_string)).IsValid()) {
// If a bogus command line flag was given, then abort.
LOG(ERROR) << "Invalid command line version: " << version_string;
return NULL;
« no previous file with comments | « chrome/app/chrome_breakpad_client.cc ('k') | chrome/browser/chrome_browser_main_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698