chrome/common/extensions/update_manifest.cc - Issue 100543005: Update all users of base::Version to explicitly specify the namespace, and clean up the header.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/update_manifest.cc

Issue 100543005: Update all users of base::Version to explicitly specify the namespace, and clean up the header. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: someday it will work Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_handlers/minimum_chrome_version_checker.cc ('k') | chrome/common/service_process_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/update_manifest.cc

diff --git a/chrome/common/extensions/update_manifest.cc b/chrome/common/extensions/update_manifest.cc

index 0ed653ff76a8e32288b96c9bef31027a41ad2324..7fd85e854404b917889d0f92f0c78d53d79be03d 100644

--- a/chrome/common/extensions/update_manifest.cc

+++ b/chrome/common/extensions/update_manifest.cc

@@ -167,7 +167,7 @@ static bool ParseSingleAppTag(xmlNode* app_node, xmlNs* xml_namespace,

*error_detail = "Missing version for updatecheck.";

return false;

}

- Version version(result->version);

+ base::Version version(result->version);

if (!version.IsValid()) {

*error_detail = "Invalid version: '";

*error_detail += result->version;

@@ -178,7 +178,7 @@ static bool ParseSingleAppTag(xmlNode* app_node, xmlNs* xml_namespace,

// Get the minimum browser version (not required).

result->browser_min_version = GetAttribute(updatecheck, "prodversionmin");

if (result->browser_min_version.length()) {

- Version browser_min_version(result->browser_min_version);

+ base::Version browser_min_version(result->browser_min_version);

if (!browser_min_version.IsValid()) {

*error_detail = "Invalid prodversionmin: '";

*error_detail += result->browser_min_version;