Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Side by Side Diff: chrome/browser/ui/startup/default_browser_prompt.cc

Issue 100543005: Update all users of base::Version to explicitly specify the namespace, and clean up the header. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: someday it will work Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/startup/default_browser_prompt.h" 5 #include "chrome/browser/ui/startup/default_browser_prompt.h"
6 6
7 #include "base/memory/weak_ptr.h" 7 #include "base/memory/weak_ptr.h"
8 #include "base/message_loop/message_loop.h" 8 #include "base/message_loop/message_loop.h"
9 #include "base/metrics/histogram.h" 9 #include "base/metrics/histogram.h"
10 #include "base/prefs/pref_registry_simple.h" 10 #include "base/prefs/pref_registry_simple.h"
(...skipping 226 matching lines...) Expand 10 before | Expand all | Expand 10 after
237 } else { 237 } else {
238 // TODO(pastarmovj): We can't really do anything meaningful here yet but 238 // TODO(pastarmovj): We can't really do anything meaningful here yet but
239 // just prevent showing the infobar. 239 // just prevent showing the infobar.
240 } 240 }
241 return; 241 return;
242 } 242 }
243 243
244 const std::string disable_version_string = 244 const std::string disable_version_string =
245 g_browser_process->local_state()->GetString( 245 g_browser_process->local_state()->GetString(
246 prefs::kBrowserSuppressDefaultBrowserPrompt); 246 prefs::kBrowserSuppressDefaultBrowserPrompt);
247 const Version disable_version(disable_version_string); 247 const base::Version disable_version(disable_version_string);
248 DCHECK(disable_version_string.empty() || disable_version.IsValid()); 248 DCHECK(disable_version_string.empty() || disable_version.IsValid());
249 if (disable_version.IsValid()) { 249 if (disable_version.IsValid()) {
250 const chrome::VersionInfo version_info; 250 const chrome::VersionInfo version_info;
251 if (disable_version.Equals(Version(version_info.Version()))) 251 if (disable_version.Equals(base::Version(version_info.Version())))
252 return; 252 return;
253 } 253 }
254 254
255 content::BrowserThread::PostTask( 255 content::BrowserThread::PostTask(
256 content::BrowserThread::FILE, FROM_HERE, 256 content::BrowserThread::FILE, FROM_HERE,
257 base::Bind(&CheckDefaultBrowserCallback, desktop_type)); 257 base::Bind(&CheckDefaultBrowserCallback, desktop_type));
258 258
259 } 259 }
260 260
261 #if !defined(OS_WIN) 261 #if !defined(OS_WIN)
262 bool ShowFirstRunDefaultBrowserPrompt(Profile* profile) { 262 bool ShowFirstRunDefaultBrowserPrompt(Profile* profile) {
263 return false; 263 return false;
264 } 264 }
265 #endif 265 #endif
266 266
267 } // namespace chrome 267 } // namespace chrome
OLDNEW
« no previous file with comments | « chrome/browser/ui/pdf/pdf_unsupported_feature.cc ('k') | chrome/browser/ui/webui/extensions/extension_settings_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698