chrome/browser/extensions/updater/extension_updater_unittest.cc - Issue 100543005: Update all users of base::Version to explicitly specify the namespace, and clean up the header.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/updater/extension_updater_unittest.cc

Issue 100543005: Update all users of base::Version to explicitly specify the namespace, and clean up the header. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: someday it will work Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/updater/extension_downloader_delegate.cc ('k') | chrome/browser/extensions/user_script_master.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/updater/extension_updater_unittest.cc

diff --git a/chrome/browser/extensions/updater/extension_updater_unittest.cc b/chrome/browser/extensions/updater/extension_updater_unittest.cc

index 43fadaa13a28e33888678d937a3edda92364e352..a6ef7ad0b8af69a31460245205d5cc5430c683e2 100644

--- a/chrome/browser/extensions/updater/extension_updater_unittest.cc

+++ b/chrome/browser/extensions/updater/extension_updater_unittest.cc

@@ -311,7 +311,7 @@ void SetupPendingExtensionManagerForTest(

pending_extension_manager->AddForTesting(

PendingExtensionInfo(id,

update_url,

- Version(),

+ base::Version(),

should_allow_install,

kIsFromSync,

kInstallSilently,

@@ -987,7 +987,7 @@ class ExtensionUpdaterTest : public testing::Test {

std::string id = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";

std::string hash;

- Version version("0.0.1");

+ base::Version version("0.0.1");

std::set<int> requests;

requests.insert(0);

scoped_ptr<ExtensionDownloader::ExtensionFetch> fetch(