chrome/browser/component_updater/update_response.cc - Issue 100543005: Update all users of base::Version to explicitly specify the namespace, and clean up the header.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/component_updater/update_response.cc

Issue 100543005: Update all users of base::Version to explicitly specify the namespace, and clean up the header. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: someday it will work Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/component_updater/update_response.cc

diff --git a/chrome/browser/component_updater/update_response.cc b/chrome/browser/component_updater/update_response.cc

index cf936588c82f3f1473792c783f23b7bcc9a436c0..f1f4b2c48a8b96ff374e5753a8c243659d5f229f 100644

--- a/chrome/browser/component_updater/update_response.cc

+++ b/chrome/browser/component_updater/update_response.cc

@@ -146,7 +146,7 @@ bool ParseManifestTag(xmlNode* manifest,

*error = "Missing version for manifest.";

return false;

}

- Version version(result->manifest.version);

+ base::Version version(result->manifest.version);

if (!version.IsValid()) {

*error = "Invalid version: '";

*error += result->manifest.version;

@@ -158,7 +158,7 @@ bool ParseManifestTag(xmlNode* manifest,

result->manifest.browser_min_version =

GetAttribute(manifest, "prodversionmin");

if (result->manifest.browser_min_version.length()) {

- Version browser_min_version(result->manifest.browser_min_version);

+ base::Version browser_min_version(result->manifest.browser_min_version);

if (!browser_min_version.IsValid()) {

*error = "Invalid prodversionmin: '";

*error += result->manifest.browser_min_version;

« no previous file with comments | « chrome/browser/component_updater/test/test_installer.cc ('k') | chrome/browser/enumerate_modules_model_win.cc » ('j') | no next file with comments »