chrome/browser/plugins/plugin_metadata_unittest.cc - Issue 100543005: Update all users of base::Version to explicitly specify the namespace, and clean up the header.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/plugins/plugin_metadata_unittest.cc

Issue 100543005: Update all users of base::Version to explicitly specify the namespace, and clean up the header. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: someday it will work Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/plugins/plugin_metadata_unittest.cc

diff --git a/chrome/browser/plugins/plugin_metadata_unittest.cc b/chrome/browser/plugins/plugin_metadata_unittest.cc

index b84843af44b32cce97808c11ae46903e6a34e1b5..0281f88e15fa96204b0bf908614720271b62163d 100644

--- a/chrome/browser/plugins/plugin_metadata_unittest.cc

+++ b/chrome/browser/plugins/plugin_metadata_unittest.cc

@@ -41,9 +41,9 @@ TEST(PluginMetadataTest, SecurityStatus) {

EXPECT_EQ(kRequiresAuthorization,

GetSecurityStatus(&plugin_metadata, "1.2.3"));

- plugin_metadata.AddVersion(Version("9.4.1"), kRequiresAuthorization);

- plugin_metadata.AddVersion(Version("10"), kOutOfDate);

- plugin_metadata.AddVersion(Version("10.2.1"), kUpToDate);

+ plugin_metadata.AddVersion(base::Version("9.4.1"), kRequiresAuthorization);

+ plugin_metadata.AddVersion(base::Version("10"), kOutOfDate);

+ plugin_metadata.AddVersion(base::Version("10.2.1"), kUpToDate);

// Invalid version.

EXPECT_EQ(kOutOfDate, GetSecurityStatus(&plugin_metadata, "foo"));

« no previous file with comments | « chrome/browser/plugins/plugin_metadata.cc ('k') | chrome/browser/prefs/session_startup_pref.cc » ('j') | no next file with comments »