Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4417)

Unified Diff: chrome_frame/dll_redirector.cc

Issue 100543005: Update all users of base::Version to explicitly specify the namespace, and clean up the header. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: someday it will work Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome_frame/dll_redirector.cc
diff --git a/chrome_frame/dll_redirector.cc b/chrome_frame/dll_redirector.cc
index f9cd8a976680944e5c69d979c3792640b27d51b0..a1e49db70f2c79d5ce910a7805936f1d13db0b4f 100644
--- a/chrome_frame/dll_redirector.cc
+++ b/chrome_frame/dll_redirector.cc
@@ -123,7 +123,7 @@ bool DllRedirector::RegisterAsFirstCFModule() {
DCHECK(first_module_handle_ == NULL);
// Build our own file version outside of the lock:
- scoped_ptr<Version> our_version(GetCurrentModuleVersion());
+ scoped_ptr<base::Version> our_version(GetCurrentModuleVersion());
// We sadly can't use the autolock here since we want to have a timeout.
// Be careful not to return while holding the lock. Also, attempt to do as
@@ -187,7 +187,7 @@ bool DllRedirector::RegisterAsFirstCFModule() {
} else {
char buffer[kSharedMemorySize] = {0};
memcpy(buffer, shared_memory_->memory(), kSharedMemorySize - 1);
- dll_version_.reset(new Version(buffer));
+ dll_version_.reset(new base::Version(buffer));
if (!dll_version_->IsValid() ||
dll_version_->Equals(*our_version.get())) {
@@ -238,15 +238,15 @@ LPFNGETCLASSOBJECT DllRedirector::GetDllGetClassObjectPtr() {
return proc_ptr;
}
-Version* DllRedirector::GetCurrentModuleVersion() {
+base::Version* DllRedirector::GetCurrentModuleVersion() {
scoped_ptr<FileVersionInfo> file_version_info(
FileVersionInfo::CreateFileVersionInfoForCurrentModule());
DCHECK(file_version_info.get());
- scoped_ptr<Version> current_version;
+ scoped_ptr<base::Version> current_version;
if (file_version_info.get()) {
current_version.reset(
- new Version(WideToASCII(file_version_info->file_version())));
+ new base::Version(WideToASCII(file_version_info->file_version())));
DCHECK(current_version->IsValid());
}
@@ -269,7 +269,7 @@ HMODULE DllRedirector::GetFirstModule() {
return first_module_handle_;
}
-HMODULE DllRedirector::LoadVersionedModule(Version* version) {
+HMODULE DllRedirector::LoadVersionedModule(base::Version* version) {
DCHECK(version);
HMODULE hmodule = NULL;
« no previous file with comments | « chrome/test/mini_installer_test/installer_test_util.cc ('k') | chrome_frame/test/dll_redirector_loading_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698