chrome/browser/extensions/external_registry_loader_win.cc - Issue 100543005: Update all users of base::Version to explicitly specify the namespace, and clean up the header.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/external_registry_loader_win.cc

Issue 100543005: Update all users of base::Version to explicitly specify the namespace, and clean up the header. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: someday it will work Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/external_provider_impl.cc ('k') | chrome/browser/extensions/updater/extension_downloader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/external_registry_loader_win.cc

diff --git a/chrome/browser/extensions/external_registry_loader_win.cc b/chrome/browser/extensions/external_registry_loader_win.cc

index 2d534d9d7af75d6f5197f6786c55fe17e4b4704a..c6ee0ad5b32dcccead6c8052aac50e3cc98c4172 100644

--- a/chrome/browser/extensions/external_registry_loader_win.cc

+++ b/chrome/browser/extensions/external_registry_loader_win.cc

@@ -146,7 +146,7 @@ void ExternalRegistryLoader::LoadOnFileThread() {

continue;

}

- Version version(WideToASCII(extension_version));

+ base::Version version(WideToASCII(extension_version));

if (!version.IsValid()) {

LOG(ERROR) << "Invalid version value " << extension_version

<< " for key " << key_path << ".";

« no previous file with comments | « chrome/browser/extensions/external_provider_impl.cc ('k') | chrome/browser/extensions/updater/extension_downloader.cc » ('j') | no next file with comments »