chrome/browser/enumerate_modules_model_win.cc - Issue 100543005: Update all users of base::Version to explicitly specify the namespace, and clean up the header.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/enumerate_modules_model_win.cc

Issue 100543005: Update all users of base::Version to explicitly specify the namespace, and clean up the header. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: someday it will work Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/enumerate_modules_model_win.cc

diff --git a/chrome/browser/enumerate_modules_model_win.cc b/chrome/browser/enumerate_modules_model_win.cc

index e45c204276e1df84b6033003292bcde0e6757b61..be2e42faf7a007c34135dcb33303a730187ada69 100644

--- a/chrome/browser/enumerate_modules_model_win.cc

+++ b/chrome/browser/enumerate_modules_model_win.cc

@@ -384,9 +384,9 @@ ModuleEnumerator::ModuleStatus ModuleEnumerator::Match(

location_hash == blacklisted.location)) {

// We have a name match against the blacklist (and possibly location match

// also), so check version.

- Version module_version(UTF16ToASCII(module.version));

- Version version_min(blacklisted.version_from);

- Version version_max(blacklisted.version_to);

+ base::Version module_version(UTF16ToASCII(module.version));

+ base::Version version_min(blacklisted.version_from);

+ base::Version version_max(blacklisted.version_to);

bool version_ok = !version_min.IsValid() && !version_max.IsValid();

if (!version_ok) {

bool too_low = version_min.IsValid() &&

« no previous file with comments | « chrome/browser/component_updater/update_response.cc ('k') | chrome/browser/extensions/api/runtime/runtime_api.cc » ('j') | no next file with comments »