chrome/browser/extensions/user_script_master.cc - Issue 100543005: Update all users of base::Version to explicitly specify the namespace, and clean up the header.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/user_script_master.cc

Issue 100543005: Update all users of base::Version to explicitly specify the namespace, and clean up the header. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: someday it will work Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/updater/extension_updater_unittest.cc ('k') | chrome/browser/extensions/webstore_installer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/user_script_master.cc

diff --git a/chrome/browser/extensions/user_script_master.cc b/chrome/browser/extensions/user_script_master.cc

index ebde012745f8f833047ace9422f409336def31e9..89a64a52e0d0ac5bc986acc787e38ef330c59877 100644

--- a/chrome/browser/extensions/user_script_master.cc

+++ b/chrome/browser/extensions/user_script_master.cc

@@ -115,7 +115,7 @@ bool UserScriptMaster::ScriptReloader::ParseMetadataHeader(

} else if (GetDeclarationValue(line, kNameDeclaration, &value)) {

script->set_name(value);

} else if (GetDeclarationValue(line, kVersionDeclaration, &value)) {

- Version version(value);

+ base::Version version(value);

if (version.IsValid())

script->set_version(version.GetString());

} else if (GetDeclarationValue(line, kDescriptionDeclaration, &value)) {

« no previous file with comments | « chrome/browser/extensions/updater/extension_updater_unittest.cc ('k') | chrome/browser/extensions/webstore_installer.h » ('j') | no next file with comments »