base/version.h - Issue 100543005: Update all users of base::Version to explicitly specify the namespace, and clean up the header.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/version.h

Issue 100543005: Update all users of base::Version to explicitly specify the namespace, and clean up the header. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: someday it will work Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/version.h

diff --git a/base/version.h b/base/version.h

index b3012eb921b1e62a803b681f03954fbb17d14cea..dfd17ef368d61f821d562dde00f4f851968a14f8 100644

--- a/base/version.h

+++ b/base/version.h

@@ -65,8 +65,4 @@ class BASE_EXPORT Version {

} // namespace base

-// TODO(xhwang) remove this when all users are updated to explicitly use the

-// namespace

-using base::Version;

#endif // BASE_VERSION_H_

« no previous file with comments | « no previous file | base/version_unittest.cc » ('j') | no next file with comments »