Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Issue 863253002: Update from https://crrev.com/312600 (Closed)

Created:
5 years, 11 months ago by qsr
Modified:
5 years, 11 months ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, esprehn, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, ojan
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5432 lines, -3661 lines) Patch
M DEPS View 2 chunks +4 lines, -4 lines 0 comments Download
M base/BUILD.gn View 5 chunks +13 lines, -14 lines 0 comments Download
M base/android/base_jni_registrar.cc View 2 chunks +24 lines, -22 lines 0 comments Download
A base/android/java/src/org/chromium/base/metrics/RecordHistogram.java View 1 chunk +62 lines, -0 lines 0 comments Download
A base/android/javatests/src/org/chromium/base/metrics/RecordHistogramTest.java View 1 chunk +78 lines, -0 lines 0 comments Download
A + base/android/record_histogram.h View 1 chunk +4 lines, -4 lines 0 comments Download
A base/android/record_histogram.cc View 1 chunk +69 lines, -0 lines 0 comments Download
M base/base.gyp View 5 chunks +10 lines, -15 lines 0 comments Download
M base/base.gypi View 2 chunks +2 lines, -1 line 0 comments Download
M base/chromeos/memory_pressure_observer_chromeos.h View 2 chunks +25 lines, -1 line 0 comments Download
M base/chromeos/memory_pressure_observer_chromeos.cc View 2 chunks +43 lines, -10 lines 0 comments Download
M base/chromeos/memory_pressure_observer_chromeos_unittest.cc View 1 chunk +4 lines, -1 line 0 comments Download
M base/debug/trace_event_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
D base/event_recorder.h View 1 chunk +0 lines, -109 lines 0 comments Download
D base/event_recorder_stubs.cc View 1 chunk +0 lines, -28 lines 0 comments Download
D base/event_recorder_win.cc View 1 chunk +0 lines, -258 lines 0 comments Download
M base/files/file_util_proxy_unittest.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M base/i18n/i18n_constants.h View 1 chunk +3 lines, -2 lines 0 comments Download
M base/i18n/i18n_constants.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M base/message_loop/message_loop.h View 4 chunks +5 lines, -3 lines 0 comments Download
M base/message_loop/message_loop.cc View 5 chunks +14 lines, -3 lines 0 comments Download
M base/message_loop/message_pump_win.cc View 2 chunks +23 lines, -1 line 0 comments Download
M base/process/launch.h View 1 chunk +19 lines, -0 lines 0 comments Download
M base/process/launch_posix.cc View 4 chunks +94 lines, -0 lines 0 comments Download
M base/process/process.h View 1 chunk +0 lines, -19 lines 0 comments Download
M base/process/process_linux.cc View 3 chunks +0 lines, -92 lines 0 comments Download
M base/process/process_metrics.h View 1 chunk +0 lines, -11 lines 0 comments Download
M base/process/process_unittest.cc View 2 chunks +0 lines, -116 lines 0 comments Download
M base/process/process_util_unittest.cc View 3 chunks +110 lines, -0 lines 0 comments Download
A base/test/android/javatests/src/org/chromium/base/test/util/MetricsUtils.java View 1 chunk +43 lines, -0 lines 0 comments Download
M base/test/launcher/unit_test_launcher.cc View 1 chunk +268 lines, -291 lines 0 comments Download
M base/tuple.h View 2 chunks +46 lines, -0 lines 0 comments Download
M build/all.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M build/android/pylib/base/test_run_factory.py View 2 chunks +9 lines, -4 lines 0 comments Download
M build/android/pylib/constants.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/device/device_utils.py View 1 chunk +6 lines, -3 lines 0 comments Download
M build/android/pylib/device/device_utils_test.py View 1 chunk +19 lines, -3 lines 0 comments Download
M build/android/pylib/gtest/test_package_apk.py View 3 chunks +9 lines, -6 lines 0 comments Download
M build/android/pylib/gtest/test_runner.py View 2 chunks +20 lines, -20 lines 0 comments Download
M build/android/pylib/instrumentation/instrumentation_test_instance.py View 4 chunks +33 lines, -0 lines 0 comments Download
M build/android/pylib/remote/device/remote_device_gtest_run.py View 1 chunk +1 line, -1 line 0 comments Download
A build/android/pylib/remote/device/remote_device_instrumentation_test_run.py View 1 chunk +55 lines, -0 lines 0 comments Download
M build/android/pylib/remote/device/remote_device_test_run.py View 3 chunks +3 lines, -3 lines 0 comments Download
D build/android/pylib/remote/device/remote_device_uirobot_run.py View 1 chunk +0 lines, -59 lines 0 comments Download
A + build/android/pylib/remote/device/remote_device_uirobot_test_run.py View 2 chunks +2 lines, -2 lines 0 comments Download
M build/android/pylib/uirobot/uirobot_test_instance.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/test_runner.py View 2 chunks +2 lines, -1 line 0 comments Download
M build/common.gypi View 3 chunks +8 lines, -2 lines 0 comments Download
M build/config/compiler/BUILD.gn View 3 chunks +54 lines, -1 line 0 comments Download
A build/config/mips.gni View 1 chunk +20 lines, -0 lines 0 comments Download
A + build/ios/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
A build/ios/coverage.gypi View 1 chunk +33 lines, -0 lines 0 comments Download
D build/linux/unbundle/openssl.gyp View 1 chunk +0 lines, -25 lines 0 comments Download
M build/linux/unbundle/replace_gyp_files.py View 1 chunk +0 lines, -1 line 0 comments Download
M cc/debug/rasterize_and_record_benchmark_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/debug/rasterize_and_record_benchmark_impl.cc View 3 chunks +43 lines, -91 lines 0 comments Download
M cc/layers/picture_layer_impl.h View 2 chunks +2 lines, -1 line 0 comments Download
M cc/layers/picture_layer_impl.cc View 7 chunks +9 lines, -10 lines 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 4 chunks +58 lines, -3 lines 0 comments Download
M cc/resources/task_graph_runner_perftest.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M cc/resources/video_resource_updater.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M cc/test/fake_layer_tree_host_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/test/fake_layer_tree_host_impl_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/test/fake_picture_layer_impl.h View 2 chunks +4 lines, -1 line 0 comments Download
M cc/test/fake_picture_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/layer_tree_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/test/test_gpu_memory_buffer_manager.cc View 4 chunks +7 lines, -5 lines 0 comments Download
M cc/trees/layer_tree_host.h View 4 chunks +7 lines, -6 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 6 chunks +9 lines, -24 lines 0 comments Download
M cc/trees/layer_tree_host_client.h View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 3 chunks +3 lines, -7 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 8 chunks +2 lines, -53 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 5 chunks +37 lines, -43 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_animation.cc View 1 chunk +15 lines, -10 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_no_message_loop.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/single_thread_proxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/single_thread_proxy.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/trees/thread_proxy.h View 2 chunks +2 lines, -0 lines 0 comments Download
M cc/trees/thread_proxy.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M crypto/nss_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/GLES2/gl2chromium_autogen.h View 3 chunks +3 lines, -0 lines 0 comments Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 39 chunks +449 lines, -68 lines 0 comments Download
M gpu/command_buffer/client/gles2_c_lib_autogen.h View 6 chunks +21 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_cmd_helper_autogen.h View 4 chunks +23 lines, -2 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.h View 2 chunks +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 3 chunks +15 lines, -72 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_autogen.h View 3 chunks +6 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_impl_autogen.h View 4 chunks +145 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest.cc View 2 chunks +83 lines, -19 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest_autogen.h View 14 chunks +43 lines, -32 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_autogen.h View 3 chunks +3 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_autogen.h View 3 chunks +3 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_impl_autogen.h View 3 chunks +9 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_autogen.h View 3 chunks +3 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_impl_autogen.h View 3 chunks +15 lines, -0 lines 0 comments Download
M gpu/command_buffer/cmd_buffer_functions.txt View 3 chunks +3 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format.h View 2 chunks +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_autogen.h View 5 chunks +120 lines, -7 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_test_autogen.h View 4 chunks +33 lines, -1 line 0 comments Download
M gpu/command_buffer/common/gles2_cmd_ids_autogen.h View 1 chunk +217 lines, -214 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_autogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h View 1 chunk +8 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/context_group.h View 5 chunks +23 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 4 chunks +10 lines, -54 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_autogen.h View 8 chunks +127 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_1.cc View 1 chunk +0 lines, -27 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_1_autogen.h View 5 chunks +30 lines, -81 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_2.cc View 1 chunk +27 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_2_autogen.h View 3 chunks +101 lines, -26 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_3_autogen.h View 1 chunk +26 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h View 4 chunks +11 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 5 chunks +47 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_programs.cc View 3 chunks +56 lines, -14 lines 0 comments Download
M gpu/command_buffer/tests/gl_manager.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M mojo/services/network/public/cpp/udp_socket_wrapper.h View 2 chunks +6 lines, -0 lines 0 comments Download
M mojo/services/network/public/cpp/udp_socket_wrapper.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M mojo/services/network/public/interfaces/network_service.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/public/interfaces/udp_socket.mojom View 4 chunks +5 lines, -5 lines 0 comments Download
M mojo/services/network/udp_socket_apptest.cc View 6 chunks +230 lines, -77 lines 0 comments Download
M mojo/services/network/udp_socket_impl.h View 3 chunks +17 lines, -5 lines 0 comments Download
M mojo/services/network/udp_socket_impl.cc View 11 chunks +132 lines, -51 lines 0 comments Download
M net/http/transport_security_state_static.h View 1 chunk +1192 lines, -1191 lines 0 comments Download
M net/http/transport_security_state_static.json View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/quic_client_session.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/spdy/spdy_headers_block_parser.h View 2 chunks +5 lines, -7 lines 0 comments Download
M net/spdy/spdy_headers_block_parser.cc View 6 chunks +27 lines, -9 lines 0 comments Download
M net/spdy/spdy_headers_block_parser_test.cc View 8 chunks +44 lines, -25 lines 0 comments Download
M net/tools/testserver/testserver.py View 2 chunks +8 lines, -1 line 0 comments Download
M net/url_request/test_url_fetcher_factory.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/url_request/test_url_fetcher_factory.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M net/url_request/url_fetcher.h View 2 chunks +15 lines, -0 lines 0 comments Download
M net/url_request/url_fetcher_core.h View 3 chunks +8 lines, -0 lines 0 comments Download
M net/url_request/url_fetcher_core.cc View 5 chunks +29 lines, -9 lines 0 comments Download
M net/url_request/url_fetcher_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/url_request/url_fetcher_impl.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M net/url_request/url_fetcher_impl_unittest.cc View 7 chunks +78 lines, -2 lines 0 comments Download
M net/websockets/websocket_handshake_stream_create_helper_test.cc View 6 chunks +14 lines, -23 lines 0 comments Download
M net/websockets/websocket_stream_test.cc View 36 chunks +92 lines, -169 lines 0 comments Download
M net/websockets/websocket_test_util.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/websockets/websocket_test_util.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M sandbox/linux/services/credentials.cc View 1 chunk +1 line, -1 line 0 comments Download
M skia/config/SkUserConfig.h View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/bindings/core/v8/WindowProxy.h View 1 chunk +1 line, -3 lines 0 comments Download
M sky/engine/bindings/core/v8/WindowProxy.cpp View 3 chunks +0 lines, -20 lines 0 comments Download
M sky/engine/platform/fonts/skia/FontCustomPlatformDataSkia.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/viewer/document_view.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 1 chunk +328 lines, -0 lines 0 comments Download
M testing/test.gni View 1 chunk +3 lines, -0 lines 1 comment Download
M tools/valgrind/gtest_exclude/cc_unittests.gtest-drmemory_win32.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/gl/gl_image_memory.h View 2 chunks +4 lines, -1 line 0 comments Download
M ui/gl/gl_image_memory.cc View 1 chunk +12 lines, -4 lines 0 comments Download
M ui/gl/gl_image_shared_memory.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
qsr
5 years, 11 months ago (2015-01-22 12:22:26 UTC) #1
qsr
Committed patchset #1 (id:1) manually as df06e5f1b36dc0093851a3346dea202dc2cb7f37 (presubmit successful).
5 years, 11 months ago (2015-01-22 12:23:02 UTC) #2
jamesr
5 years, 11 months ago (2015-01-22 18:19:01 UTC) #3
Message was sent while issue was closed.
https://codereview.chromium.org/863253002/diff/1/testing/test.gni
File testing/test.gni (right):

https://codereview.chromium.org/863253002/diff/1/testing/test.gni#newcode129
testing/test.gni:129: if (defined(invoker.apk_asset_location)) {
aha, there's the ticket

Powered by Google App Engine
This is Rietveld 408576698