sky/engine/platform/fonts/skia/FontCustomPlatformDataSkia.cpp - Issue 863253002: Update from https://crrev.com/312600

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/platform/fonts/skia/FontCustomPlatformDataSkia.cpp

Issue 863253002: Update from https://crrev.com/312600 (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/platform/fonts/skia/FontCustomPlatformDataSkia.cpp

diff --git a/sky/engine/platform/fonts/skia/FontCustomPlatformDataSkia.cpp b/sky/engine/platform/fonts/skia/FontCustomPlatformDataSkia.cpp

index c675bc0830d24afb22232c4536c49cb9ac197561..dd0434308caaf871c6db534cd47c36f7951c161b 100644

--- a/sky/engine/platform/fonts/skia/FontCustomPlatformDataSkia.cpp

+++ b/sky/engine/platform/fonts/skia/FontCustomPlatformDataSkia.cpp

@@ -69,8 +69,8 @@ PassOwnPtr<FontCustomPlatformData> FontCustomPlatformData::create(SharedBuffer*

return nullptr; // validation failed.

buffer = transcodeBuffer.get();

- RefPtr<SkMemoryStream> stream = adoptRef(new SkMemoryStream(buffer->getAsSkData().get()));

- RefPtr<SkTypeface> typeface = adoptRef(SkTypeface::CreateFromStream(stream.get()));

+ SkMemoryStream* stream = new SkMemoryStream(buffer->getAsSkData().get());

+ RefPtr<SkTypeface> typeface = adoptRef(SkTypeface::CreateFromStream(stream));

if (!typeface)

return nullptr;