Add sampler related ES3 APIs to command buffer.

Add sampler related ES3 APIs to command buffer.

Including:
  glGetSamplerParameter*v
  glSamplerParameter*v
  glSamplerParameteri/f
  glBindSampler
  glDeleteSamplers
  glGenSamplers
  glIsSampler

One major feature that I add is the client/service ID mapping handling.

BUG=429053
TEST=gpu_unittests
R=bajones@chromium.org

Committed: https://crrev.com/bcb3fdd69b3a04edf3f48e333ea42a8ec6f0177b
Cr-Commit-Position: refs/heads/master@{#307810}

[Zhenyao Mo, 2014-12-10 01:54:10]

bajones: please review.
kbr,sievers, vmiura: FYI, but feel free to review.

[Zhenyao Mo, 2014-12-10 01:59:12]

https://codereview.chromium.org/788123002/diff/1/gpu/command_buffer/service/g...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/788123002/diff/1/gpu/command_buffer/service/g...
gpu/command_buffer/service/gles2_cmd_decoder.cc:5869:
glSamplerParameterf(sampler, pname, params[0]);
This is use glSamplerParameterf to implement glSamplerParameterfv, because only
one param is allowed.

https://codereview.chromium.org/788123002/diff/1/gpu/command_buffer/service/g...
gpu/command_buffer/service/gles2_cmd_decoder.cc:5875:
glSamplerParameteri(sampler, pname, params[0]);
This is use glSamplerParameteri to implement glSamplerParameteriv, because only
one param is allowed.

[bajones, 2014-12-10 23:13:58]

https://codereview.chromium.org/788123002/diff/1/gpu/command_buffer/client/gl...
File gpu/command_buffer/client/gles2_implementation.cc (right):

https://codereview.chromium.org/788123002/diff/1/gpu/command_buffer/client/gl...
gpu/command_buffer/client/gles2_implementation.cc:2318: GLsizei /* n */, const
GLuint* /* samplers */) {
Just double checking: Is this intended to be an empty function? I see that at
the callsite it immediately calls helper->GenSamplersImmediate which appears to
be where all the real work is done, so this may just need to be here to satisfy
the autogenerated stubs, but I'd like to verify that with you first.

[Zhenyao Mo, 2014-12-10 23:41:15]

https://codereview.chromium.org/788123002/diff/1/gpu/command_buffer/client/gl...
File gpu/command_buffer/client/gles2_implementation.cc (right):

https://codereview.chromium.org/788123002/diff/1/gpu/command_buffer/client/gl...
gpu/command_buffer/client/gles2_implementation.cc:2318: GLsizei /* n */, const
GLuint* /* samplers */) {
On 2014/12/10 23:13:58, bajones wrote:
> Just double checking: Is this intended to be an empty function? I see that at
> the callsite it immediately calls helper->GenSamplersImmediate which appears
to
> be where all the real work is done, so this may just need to be here to
satisfy
> the autogenerated stubs, but I'd like to verify that with you first.

Yes, it's only added for the purpose of VertexArraysOES.  No other Gen*Helper
function is necessary.

[bajones, 2014-12-10 23:44:00]

lgtm

[Zhenyao Mo, 2014-12-10 23:45:26]

The CQ bit was checked by zmo@chromium.org

[commit-bot: I haz the power, 2014-12-10 23:48:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/788123002/1

[commit-bot: I haz the power, 2014-12-11 00:49:28]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-12-11 00:50:14]

Patchset 1 (id:??) landed as
https://crrev.com/bcb3fdd69b3a04edf3f48e333ea42a8ec6f0177b
Cr-Commit-Position: refs/heads/master@{#307810}

[piman, 2015-01-09 07:10:56]

piman@chromium.org changed reviewers:
+ piman@chromium.org

[piman, 2015-01-09 07:10:57]

https://codereview.chromium.org/788123002/diff/1/gpu/command_buffer/service/g...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/788123002/diff/1/gpu/command_buffer/service/g...
gpu/command_buffer/service/gles2_cmd_decoder.cc:5867: GLuint sampler, GLenum
pname, const GLfloat* params) {
These 2 methods need to be disabled if !unsafe_es3_apis_enabled(), otherwise
they will call into NULL on an ES2 implementation, and crash the GPU process.

https://codereview.chromium.org/788123002/diff/1/gpu/command_buffer/service/g...
File gpu/command_buffer/service/gles2_cmd_decoder_autogen.h (right):

https://codereview.chromium.org/788123002/diff/1/gpu/command_buffer/service/g...
gpu/command_buffer/service/gles2_cmd_decoder_autogen.h:92:
group_->GetSamplerServiceId(sampler, &sampler);
This needs to properly handle failure.
Spec says GL_INVALID_OPERATION needs to be generated if the name was not created
by GenSamplers (or 0).
If that happens, here, you're ignoring the failure, and passing the client id to
the driver instead of raising an error.

[Zhenyao Mo, 2015-01-09 17:45:28]

https://codereview.chromium.org/788123002/diff/1/gpu/command_buffer/service/g...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/788123002/diff/1/gpu/command_buffer/service/g...
gpu/command_buffer/service/gles2_cmd_decoder.cc:5867: GLuint sampler, GLenum
pname, const GLfloat* params) {
On 2015/01/09 07:10:57, piman (Very slow to review) wrote:
> These 2 methods need to be disabled if !unsafe_es3_apis_enabled(), otherwise
> they will call into NULL on an ES2 implementation, and crash the GPU process.

The check happens in Handle* function, which is the only place that calls the
Do* function.

https://codereview.chromium.org/788123002/diff/1/gpu/command_buffer/service/g...
File gpu/command_buffer/service/gles2_cmd_decoder_autogen.h (right):

https://codereview.chromium.org/788123002/diff/1/gpu/command_buffer/service/g...
gpu/command_buffer/service/gles2_cmd_decoder_autogen.h:92:
group_->GetSamplerServiceId(sampler, &sampler);
On 2015/01/09 07:10:57, piman (Very slow to review) wrote:
> This needs to properly handle failure.
> Spec says GL_INVALID_OPERATION needs to be generated if the name was not
created
> by GenSamplers (or 0).
> If that happens, here, you're ignoring the failure, and passing the client id
to
> the driver instead of raising an error.

Will do.